Closed (fixed)
Project:
Search API Synonym
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Aug 2021 at 11:50 UTC
Updated:
3 Nov 2021 at 14:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
andriyun commentedPlease review MR3
Comment #4
admin@azhark.com commentedTested merge request !3, and it is working perfectly.
Testing Versions:
Drupal Version: 8.9.0 (Minimal Installation)
Search API Synonym Version: 8.x-1.2
Attached Before and after screenshot.
Looks good to me.
Comment #5
admin@azhark.com commentedComment #7
laravz commentedI've changed the syntax to match the drupal standards/documentation, would appreciate it if someone could do a quick review as I do not wish to approve my own changes.
Comment #8
HBraaksma commentedI don't have the authority to approve, but the MR looks good to me.
Comment #9
andriyun commentedLooks good to me as well
The issue is already in RTBC status
So next turn is on the maintainer side
Comment #10
laravz commentedI've was granted co-maintainership yesterday so will be able to merge this