Allow modules to modify JS settings for the JPlayer [#3226331]

Problem/Motivation

Due to analytics and tracking, we need to add a variable parameter value to the MP3 player being rendered on a node.
Doing this change through the templating system was complicated as the relationship was 2 references away.
Using view alter hooks was not possible because the JS settings were made before the view was rendered.

Proposed resolution

Add an alter hook before sending the render array that contains the JS settings.

Comment	File	Size	Author
#9	audiofield-3226331-10.patch	3.28 KB	afsch
#8	issue-3226331--8.x-1.9.patch	2.74 KB	betoaveiga
#5	issue-3226331.patch	2.53 KB	betoaveiga
#2	issue-3226331.patch	2.65 KB	betoaveiga

Issue fork audiofield-3226331

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3226331-allow-modules-to changes, plain diff MR !21
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

2 August 2021 at 15:04

BetoAveiga created an issue. See original summary.

Comment #2

betoaveiga

Spanish

Daule, Guayas

commented 2 August 2021 at 15:06

Status	File	Size
new	issue-3226331.patch	2.65 KB

Uploading the patch to allow alter JS settings for the JPlayer.

Comment #3

daniel.moberly commented 2 August 2021 at 15:51

This patch does not apply against dev. Can you reroll?

Comment #4

betoaveiga

Spanish

Daule, Guayas

commented 2 August 2021 at 17:25

Sure, Daniel, I will add it as a reminder for later.

Comment #5

betoaveiga

Spanish

Daule, Guayas

commented 2 August 2021 at 21:44

Status	File	Size
new	issue-3226331.patch	2.53 KB

Rerolling for latest 8.x-1.x.

Comment #6

daniel.moberly commented 2 August 2021 at 22:17

Status:

Active

» Needs work

This patch currently breaks all other audiofield types (wavesurfer, etc.) using the constructor

ArgumentCountError: Too few arguments to function Drupal\audiofield\AudioFieldPluginBase::__construct(), 7 passed in /var/www/html/base/web/modules/custom/audiofield/src/Plugin/AudioPlayer/WavesurferAudioPlayer.php on line 44 and exactly 8 expected in Drupal\audiofield\AudioFieldPluginBase->__construct() (line 67 of modules/custom/audiofield/src/AudioFieldPluginBase.php).