Problem/Motivation

Looks like https://git.drupalcode.org/project/drupalci_environments/-/blob/producti... enables rewrite but not headers.

Drupal's .htaccess file adds stuff within <IfModule mod_headers.c>. #2854817: Duplicate X-Content-Type-Options headers both with the value nosniff discovered a bug with it, and we want to ensure that the test coverage for it runs correctly on DrupalCI.

Steps to reproduce

Proposed resolution

Add a2enmod headers within apache.m4.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drupalci_environments-3226187

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    effulgentsia created an issue. See original summary.

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented
    Assigned: Unassigned » andypost
    Related issues: +#3387737: Split PHP image into php(cli/apache) and yarn(node/nightwatch)

    makes sense

    • andypost committed 7b20314e on dev 
      Issue #3226187 by effulgentsia, andypost: Enable mod_headers and...
    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented
    Title: Enable mod_headers on Apache » Enable mod_headers and mod_expires on Apache
    Assigned: andypost » Unassigned
    Status: Active » Needs review

    now images are building and I added mod_expires as it also mentioned in .htaccess

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented

    Started test in https://git.drupalcode.org/project/drupal/-/merge_requests/7745

    ref https://git.drupalcode.org/issue/drupal-3386474/-/pipelines/156733

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented

    And the run for D7 https://git.drupalcode.org/issue/drupal-3443234/-/pipelines/156737

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented

    D7 has fail
    - https://git.drupalcode.org/issue/drupal-3443234/-/jobs/1432789
    - https://git.drupalcode.org/issue/drupal-3443234/-/jobs/1432799

    Detailed test results
---------------------
---- BootstrapPageCacheTestCase ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Other      bootstrap.test     197 BootstrapPageCacheTestCase->testPag
    X-Content-Type-Options header was sent.
    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented

    And that's expected behavior that header is always set https://git.drupalcode.org/project/drupal/-/blob/7.x/.htaccess?ref_type=...

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented
    Related issues: +#3116482: Duplicate X-Content-Type-Options headers both with the value nosniff [D7]

    D7 has known issue, so testing within #3116482: Duplicate X-Content-Type-Options headers both with the value nosniff [D7]

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented
    Status: Needs review » Reviewed & tested by the community

    Tests on D7 using patch went green, so gonna commit to production #3116482-9: Duplicate X-Content-Type-Options headers both with the value nosniff [D7]

    • andypost committed 9c756fcb on production 
      Issue #3226187 by effulgentsia, andypost: Enable mod_headers and...
    andypost’s picture

    andypost
    he/him
    Primary language Russian
    commented
    Status: Reviewed & tested by the community » Fixed

    8.1-8.3 deployed https://git.drupalcode.org/project/drupalci_environments/-/jobs/1433415

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.