Closed (fixed)
Project:
Drupal core
Version:
9.3.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 Jul 2021 at 06:59 UTC
Updated:
13 Aug 2021 at 08:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gábor hojtsylifecycle_description, like the module has anameanddescription?Comment #3
catchI think it would be good for these to link to a page on Drupal.org rather than directly to replacement modules, this way we can update the documentation page over time without needing to update core. This brings up the question do we always want a custom message, or would a standard message with
lifecycle_linkkey work?Comment #4
larowlanYeah, that's a much better idea 🧠
Updating the issue summary
Comment #5
larowlanAdded a check to the info parser that this is present and valid for both obsolete and deprecated.
Added text to https://www.drupal.org/about/core/policies/core-change-policies/deprecat... for Simpletest and Entity Reference.
Comment #6
andypostURL validation is tricky, and reminds me about #295021: Expand/augment UrlHelper::isValid() to improve correctness and handle more URL types
Comment #7
gábor hojtsy@andypost: hm, the sub-issues linked from #295021: Expand/augment UrlHelper::isValid() to improve correctness and handle more URL types have all been resolved. Not sure what's left of that at this point? Also that less used link protocols are not supported does not really concern this issue IMHO. That would not stop people from being able to assign a docs link.
I think the validation looks good, the tests are comprehensive. UI exposure of the value is in other issues. The requirement for this came from a UX team meeting last week to present this to users as remediation for the warning shown. So IMHO good to proceed.
Ps. the test link looks fun :D
Comment #9
catchCommitted 3726333 and pushed to 9.3.x. Thanks!
We need to update https://www.drupal.org/node/3215042 still.
Comment #10
gábor hojtsyUpdated https://www.drupal.org/node/3215042/revisions/view/12360437/12360446 :)