Problem/Motivation

Field data not migrated from D7 to D8/D9.

Steps to reproduce

Enable module in D7 and configure a block with the Block class field. Migrate block from D7 to D8/D9.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 block_class-migration-3225653-4--complete.patch9.54 KBhuzooka
#4 block_class-migration-3225653-4--test-only.patch8.79 KBhuzooka
#3 3225653-3-Migrate-D7-block_class-to-D8-D9.patch778 bytesamarlata

Issue fork block_class-3225653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amarlata created an issue. See original summary.

amarlata’s picture

amarlata
Amarlata
Primary language English
commented
Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
amarlata’s picture

amarlata
Amarlata
Primary language English
commented
StatusFileSize
new 3225653-3-Migrate-D7-block_class-to-D8-D9.patch778 bytes
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Title: [PP-2] Migrate D7 block_class to D8/D9 » Migrate D7 block_class to D8/D9
Status: Active » Needs review
StatusFileSize
new block_class-migration-3225653-4--test-only.patch8.79 KB
new block_class-migration-3225653-4--complete.patch9.54 KB

Adding test coverage.

Interdiff isn't provided: the difference between #3 and this is the test-only patch.

We shouldn't postpone this, so removing the [PP-*] prefix.

Thank you, @amarlata!

The last submitted patch, 4: block_class-migration-3225653-4--test-only.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
fengtan’s picture

fengtan
Location Montreal, Canada
commented

A workaround that seems to work (if you are using a custom migration and are able to edit the yml migration file):

# my_block_migration.yml
source:
  ...
process:
  third_party_settings/block_class/classes: css_class
destination:
  ...

kunal_sahu made their first commit to this issue’s fork.

kunal_sahu opened merge request !11

kunal_sahu’s picture

kunal_sahu commented

I have created an MR , please merge . Thanks

DYdave made their first commit to this issue’s fork.

  • DYdave committed e2b881c0 on 8.x-1.x authored by kunal_sahu 
    Issue #3225653 by DYdave, kunal_sahu, huzooka, amarlata: Added support...
dydave’s picture

dydave commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#3428214: Automated Drupal 11 compatibility fixes for bartik, +#3434485: Automated Drupal 11 compatibility fixes for seven

Thanks a lot everyone for your great help on this issue and sorry for the delay of this reply.

Quick follow-up:
Easily rebased MR!11 and started running the tests locally on D10.
I quickly noticed the fixtures were based on themes bartik and seven which have been removed in core D10 and moved to contrib.

After adding the themes locally with composer, the tests ran successfully without any change to the work from #4!
Great job getting some tests added!

Lastly, for D11 (phpunit next major), adding the bartik and seven themes with composer was not an option since they don't seem to have compatible versions at this moment, see:

 
Therefore, the D7 Migrate Kernel Tests had to be disabled/excluded temporarily for D11.
 
The changes have been merged in the 8.x-1.x branch at #12, thus marking this issue as Fixed for now.
 
Feel free to let us know if you have any questions, suggestions or concerns on any of the recent code changes or this ticket in general, we would be glad to help!
 
Thanks again everyone for the great work and contributions!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.