Problem/Motivation

When running tests, a Drupal 10 deprecation notice is printed. This is triggered by features.services.yml:

  features.manager:
    class: Drupal\features\FeaturesManager
    arguments: ['@app.root', '@entity_type.manager', '@config.factory', '@config.storage', '@config.manager', '@module_handler', '@features.config_update', '@extension.list.module']

Deprecation changelog: https://www.drupal.org/node/3080612

Proposed resolution

Change '@app.root' to '%app.root%'

Issue fork features-3224696

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mark_fullmer created an issue. See original summary.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Sounds good, patch welcome.

shriaas’s picture

shriaas
Location Pune
commented
Assigned: mark_fullmer » shriaas

I will give it a try

shriaas’s picture

shriaas
Location Pune
commented
Issue tags: +Drupal 10 porting day

immaculatexavier made their first commit to this issue’s fork.

Shriaas opened merge request !18

shriaas’s picture

shriaas
Location Pune
commented
Assigned: shriaas » Unassigned
Status: Active » Needs review

Created MR based on the proposed resolution.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Needs review » Needs work

Strictly speaking, this change breaks with Drupal 8. As such, IMO we should stop explicitly declaring support as well.

Looks like we need a change to the info.yml file as well. Setting back to NW.

core_version_requirement: ^8.8 || ^9 --> core_version_requirement: ^9 || ^10

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Version: 8.x-4.x-dev » 5.0.x-dev
Status: Needs work » Needs review

Switching to 5.0.x, which will not be D8 compatible. We can make incremental improvements here and leave other fixes to #3263995: Remove Drupal 8 compatibility, require a supported version of core.

shriaas’s picture

shriaas
Location Pune
commented

@Luke.Leber there is already an issue created by the project update bot for D10 compatibility fixes which includes changes for info.yml file, check this: https://www.drupal.org/project/features/issues/3297177
So we can keep this issue just for fixing "app.root.factory".
Otherwise, we can convert it to a D10 compatibility issue to keep track of things missed by the project update bot, but I'll leave that up to the maintainer to decide.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Merged, thanks!

  • nedjo committed a4801ce on 5.0.x 
    Issue #3224696: fix remaining app.root calls

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.