The function datetime_date_default_time() is deprecated.
All calls should be removed/refactored to use date functions.

More info: https://api.drupal.org/api/drupal/core%21modules%21datetime%21datetime.m...

CommentFileSizeAuthor
#5 3224626.patch2.03 KBimre.horjan

Issue fork bootstrap_datepicker-3224626

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

imre.horjan created an issue. See original summary.

imre.horjan opened merge request !2

imre.horjan’s picture

imre.horjan
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
imre.horjan’s picture

imre.horjan
Primary language Hungarian
Location Hungary
commented
Assigned: imre.horjan » Unassigned
imre.horjan’s picture

imre.horjan
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3224626.patch2.03 KB

Here's a patch

Status: Needs review » Needs work

The last submitted patch, 5: 3224626.patch, failed testing. View results

imre.horjan’s picture

imre.horjan
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review

The patch failed testing because there's no test coverage in code.
It can be applied by composer.

imre.horjan’s picture

imre.horjan
Primary language Hungarian
Location Hungary
commented

Hi Martijn,
This code change is included in the latest patch of https://www.drupal.org/project/bootstrap_datepicker/issues/3147249#comme...
I couldn't find that issue in the queue because that's closed already.
Could you please merge this or apply the patch provided in the D9 compatibility issue?
Many thanks

tomefa’s picture

tomefa commented
Status: Needs review » Reviewed & tested by the community

Original patch was working, i check including both 2 separates tickets:

And this make the module compatible with Drupal 9 ;)

Martijn de Wit made their first commit to this issue’s fork.

martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.