[D9] Migrate Magician

About the issues raised by PAreview:

1. The migmag_missing_plugins.module does not implement hook_help():
   Migmag Missing Plugins is a test module. I don't think it makes any sense to implement the help hook (and write help copy) for a test module. Or am I wrong?

2. CS issue in RollbackableComponentEntityDisplayBase:
   The report points to a return statement at the end of a class method. I think (hope) that this is caused by the misinterpreted [] language construct right before the statement.

Re #2.2:
My suspicion was confirmed: changing [] to list() eliminated the reported CS error.

Diff:

diff --git a/migmag_rollbackable/src/Plugin/migrate/destination/RollbackableComponentEntityDisplayBase.php b/migmag_rollbackable/src/Plugin/migrate/destination/RollbackableComponentEntityDisplayBase.php
index ea0f52a..3375c6a 100644
--- a/migmag_rollbackable/src/Plugin/migrate/destination/RollbackableComponentEntityDisplayBase.php
+++ b/migmag_rollbackable/src/Plugin/migrate/destination/RollbackableComponentEntityDisplayBase.php
@@ -38,11 +38,11 @@ abstract class RollbackableComponentEntityDisplayBase extends ComponentEntityDis
       }
     }
 
-    [
+    list(
       $entity_type,
       $bundle,
-      $mode,
-    ] = array_values($destination_ids ?? $row_or_destination_ids);
+      $mode
+    ) = array_values($destination_ids ?? $row_or_destination_ids);
 
     return $this->getEntity($entity_type, $bundle, $mode)->getConfigDependencyName();
   }

@apaderno, thanks for the swift response!

Changed target branch from 1.0.x to 1.1.x.

Explanation of the raised PAreview issues:

1. The migmag_missing_plugins.module does not implement hook_help().

   migmag_missing_plugins is a test module. In #4, @apaderno and I agreed on that test modules don't have to implement hook_help.

2. FILE: ...p/eflmhwsj/migmag_lookup/src/Plugin/migrate/process/MigMagLookup.php
   --------------------------------------------------------------------------
   80 | ERROR | [ ] Tags must be grouped together in a doc comment
   87 | ERROR | [ ] Tags must be grouped together in a doc comment
   90 | ERROR | [ ] Tags must be grouped together in a doc comment
   97 | ERROR | [ ] Tags must be grouped together in a doc comment
   

   These are misinterpreted code examples wrapped by @code and @endcode.

3. FILE: ...p/eflmhwsj/migmag_lookup/src/Plugin/migrate/process/MigMagLookup.php
   --------------------------------------------------------------------------
   261 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
   262 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
   263 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
   264 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
   266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
   268 | ERROR | [x] Line indented incorrectly; expected -4 spaces, found 8
   269 | ERROR | [x] Line indented incorrectly; expected -4 spaces, found 8
   270 | ERROR | [x] Line indented incorrectly; expected -4 spaces, found 8
   271 | ERROR | [x] Line indented incorrectly; expected -4 spaces, found 8
   276 | ERROR | [x] Line indented incorrectly; expected -4 spaces, found 8
   277 | ERROR | [x] Line indented incorrectly; expected -2 spaces, found 10
   278 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   279 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   280 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   281 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 14
   282 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   283 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   284 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 14
   285 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   286 | ERROR | [x] Line indented incorrectly; expected -2 spaces, found 10
   287 | ERROR | [x] Line indented incorrectly; expected -2 spaces, found 10
   288 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   289 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 12
   290 | ERROR | [x] Line indented incorrectly; expected -2 spaces, found 10
   291 | ERROR | [x] Line indented incorrectly; expected -4 spaces, found 8
   292 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
   

   Misinterpreted [] constructs.

4. FILE: ..._lookup/tests/src/Kernel/Plugin/migrate/process/MigMagLookupTest.php
   --------------------------------------------------------------------------
   FOUND 4 ERRORS AFFECTING 4 LINES
   --------------------------------------------------------------------------
   895 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
   896 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
   898 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
   900 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
   

   Misinterpreted [] constructs.

5. FILE: ...lugin/migrate/destination/RollbackableComponentEntityDisplayBase.php
   --------------------------------------------------------------------------
   FOUND 1 ERROR AFFECTING 1 LINE
   --------------------------------------------------------------------------
   47 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
   --------------------------------------------------------------------------
   

   Misinterpreted [] constructs.

Thanks for your trust!