Olivero's libraries file does not have a version: VERSION key. See Claro's libraries file for an example.

While we're in there, it makes sense to alphabetize the libraries.

Issue fork drupal-3223314

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

andy-blum made their first commit to this issue’s fork.

andy-blum opened merge request !935

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

Added some comments in the MR. filter.theme and menu-sidebar are out of order.

imalabya made their first commit to this issue’s fork.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs work » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

filter.theme: should be after feed

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

This looks good! RTBC!

  • catch committed 29bead4 on 9.3.x 
    Issue #3223314 by andy-blum, imalabya, mherchel: olivero.libraries.yml...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 29bead4 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.