Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
General code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Jul 2021 at 16:26 UTC
Updated:
25 Jan 2022 at 08:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
johne commentedHere is that patch.
Comment #3
drunken monkeyThanks for reporting this, and sorry it even happened! By rights, we probably shouldn’t have just removed a
publicmethod, and certainly not replaced it by aprotectedone. So, in addition to making itpublic, we might also want to bring backContentEntity::filterValidItemIds()as a reference to the new one? (Maybe deprecating it, though?)Also, as the method continues to be independent of the class instance, it should probably still be
static, as it was before? Would also make it easier for you to call it, I think. (And calling it as an instance method would still be supported, though maybe reported as code smell.)What would you say? (Also, feedback/opinions from others very welcome.)
Attached patch would implement both of the above changes, but not 100% sure yet. (Deprecation would also need a change record, of course, if we go that route.)
(BC should not be an issue, I think, as it’s highly unlikely that anyone inherits from
ContentEntityTrackingManagerand overridesfilterValidItemIds(). Still, it’s probably technically a BC break.)Comment #5
drunken monkeyCommitted, with the deprecation. It’s pretty clear this is the clean thing to do, even though nobody seems to have noticed this for over a year (and three releases).
Thanks again for reporting this!