Problem/Motivation

Code sniffer check reports for the various issues with coding standards. See report https://www.drupal.org/pift-ci-job/1839301

Steps to reproduce

See test report.

Proposed resolution

Fix all PHPCS issues.

CommentFileSizeAuthor
#13 image (13).png51.8 KBlibbna
#10 Captura de tela de 2022-03-21 15-20-36.png107.34 KBelber
#8 Captura de tela de 2022-03-21 10-58-33.png37.18 KBelber
#8 Captura de tela de 2022-03-21 10-02-23.png128.2 KBelber
#8 Captura de tela de 2022-03-21 09-59-25.png92.34 KBelber
#5 3222384_phpcs_error.png112.92 KBsourabhjain

Issue fork queue_ui-3222384

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Related issues: +#3222385: Update Drush support

queue_ui.drush.inc file can be omitted in favor of #3222385: Update Drush support

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

I am working on this.

sourabhjain opened merge request !10

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
StatusFileSize
new 3222384_phpcs_error.png112.92 KB

Created a MR and a print of the remaining task ( i don't know this module enough to add Docs to the classes )

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
Issue summary: View changes
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs review » Needs work
StatusFileSize
new Captura de tela de 2022-03-21 09-59-25.png92.34 KB
new Captura de tela de 2022-03-21 10-02-23.png128.2 KB
new Captura de tela de 2022-03-21 10-58-33.png37.18 KB

Hi I applied the changes and revised the issue using this command: phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/queue_ui/

This command checks if Drupal coding standards is correct ( https://www.drupal.org/docs/contributed-modules/code-review-module/php-c...)

And then I had this return

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will try to work on this.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
StatusFileSize
new Captura de tela de 2022-03-21 15-20-36.png107.34 KB

Hi everyone I worked on this issue but I couldn't to resolve all threads and then the issue's status is needs work, thank you

Ruturaj Chaubey made their first commit to this issue’s fork.

ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented
Status: Needs work » Needs review

Fixed the coding standard issues in the recent commit.

libbna’s picture

libbna commented
Status: Needs review » Needs work
StatusFileSize
new image (13).png51.8 KB

Reviewed #11 MR and found 2 errors.

chakkche’s picture

chakkche commented
Assigned: Unassigned » chakkche
chakkche’s picture

chakkche commented
Assigned: chakkche » Unassigned
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Version: 8.x-2.x-dev » 3.0.x-dev

  • voleger committed 1ecc957 on 3.0.x authored by sourabhjain 
    Issue #3222384 by sourabhjain, voleger, elber, Ruturaj Chaubey, chakkche...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs work » Fixed

Fixed, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.