Closed (fixed)
Project:
Notify
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Plan
Assigned:
Reporter:
Created:
1 Jul 2021 at 15:10 UTC
Updated:
13 Nov 2021 at 16:09 UTC
Jump to comment: Most recent, Most recent file
Problem/Motivation
Notify let users select how much of a post to include in a notification. The alternatives are:
- Title only
- Title + Teaser/Excerpt
- Title + Body
- Title + Body + Fields
However, whatever setting is choosen, what is sent is "Title only".
Steps to reproduce
Set up a user with one of the other options. Trigger a notification. Observe that option is ignored.
Proposed resolution
Remove this feature/option, and always send notifictions by "title only".
This appears to be the option that see the most use. The three other options also have issues with formatting, when a HTML-formatted body, etc. is sent in a plain text email.
Remaining tasks
I am going to leave this open for discussion by the project's users for two weeks. If there are not significant opposition to removing this feature, it will be removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff-5-7.txt | 1.75 KB | gisle |
| #7 | notify-remove_how_much-3221733-7.patch | 14.45 KB | gisle |
| #5 | 3221733-5.patch | 13.17 KB | larisse |
Comments
Comment #2
cbeem commentedIn my case I do not require anything other that the title.
In /src/form/usersettings.php I have done this as a temporary fix to hide non functioning options to the user:
Line 152
$form['notify_page_detailed']['teasers'] = [
'#type' => 'radios',
'#title' => $this->t('How much to include?'),
'#default_value' => $notify->teasers,
'#options' => [
$this->t('Title only'),
//$this->t('Title + Teaser/Excerpt'),
//$this->t('Title + Body'),
//$this->t('Title + Body + Fields'),
],
'#description' => $this->t(' '),
I have then changed all entries in the database to "Title only". Actually, in the entire history of the Drupal 7 site, only one user had ever chosen another option to "Title only".
Thx
Comment #3
gisleIf you use this project, please review the plan outlined in the issue summary. State whether you agree or disagree. If you disagree, also say why this feature should remain.
The current maintainer has no use for this feature, and wants to remove it. It is rather complex to implement, given the the fact that nodes are HTML, while notifications are plain text.
If the conclusion is that it should stay, it will need the community to produce the patches required for it to be implemented. I'm not going to work on this myself.
If it is to be removed, the cleanup will happen immedately after the stipulated two weeks discussion.
Comment #4
gisleChanged title to reflect proposed solution.
Comment #5
larisse commentedHi! I created a patch to this issue.
Comment #6
gislePatch in comment#6 applies cleanly.
However, it misses out on the following:
teaserfield fromhook_schema(),but does not implementhook_update_N()to update legacy databases.Comment #7
gisleNew patch, fixing the problems reported in comment #6. Please review.
Comment #9
gislePushed to the latest snapshot of 2.0.x-dev.
Comment #10
larisse commentedHi @gisle!
Sorry for the reported absences and thanks for the fixed. I'll pay more attention for next patch.
Comment #12
gisleThis should also be done for the Drupal 7 version.
Use case for this is GDPR. The node sometimes contains personal data, and email is not always sent encrypted unless the site's MTA is set up with Enforce TSL. Also: Some European users use mail systems located outside the EU (e.g. GMail) that are subject to laws like the US Patriot Act that overrule the protections and freedoms EU citizens should enjoy. The only way to make this module GDPR compliant is to make sure that no personal data is sent in unencrypted emails.
Beside, The "Title" only option covers the main use case of this module (to alert about new content on a webside) well enough, and is the option that most users seem to prefer.
Comment #14
gisleThis is now in the latest snapshot of 7.x-1.x.