Problem/Motivation

Since the list of node operations can go very long , it would be great to have a filter called 'Node Filter' that would filter the logs via a particular node type

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 added-feature-node-type-filter-3221669-8.patch7.58 KBajv009
#3 added-feature-node-type-filter-3221669.patch4.41 KBanjali rathod
#6 added-feature-node-type-filter-3221669-7.patch6.99 KBajv009
#5 added-feature-node-type-filter-3221669-5.patch10.15 KBajv009
#2 added-node-type-filter-3221669.patch4.26 KBanjali rathod

Comments

Anjali Rathod created an issue. See original summary.

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Assigned: anjali rathod » Unassigned
Status: Active » Needs review
StatusFileSize
new added-node-type-filter-3221669.patch4.26 KB
anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
StatusFileSize
new added-feature-node-type-filter-3221669.patch4.41 KB

Another small change in this patch

ajv009’s picture

ajv009 commented
Assigned: Unassigned » ajv009
Status: Needs review » Needs work

Should not use $_SESSION directly, instead use DI and call user.tempstore service.

Using Drupal 8 services provides needed abstraction and structure for interacting with a global construct. It's part of an overall architecture that allows developers to build and extend complex applications sustainably.

ajv009’s picture

ajv009 commented
Assigned: ajv009 » Unassigned
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new added-feature-node-type-filter-3221669-5.patch10.15 KB

I added the temp store service, rest everything is good.

ajv009’s picture

ajv009 commented
StatusFileSize
new added-feature-node-type-filter-3221669-7.patch6.99 KB

Had few coding standard issues.

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Status: Reviewed & tested by the community » Needs work

Please update the validateForm condition

ajv009’s picture

ajv009 commented
StatusFileSize
new added-feature-node-type-filter-3221669-8.patch7.58 KB

Ops, I missed it.

ajv009’s picture

ajv009 commented
Status: Needs work » Needs review
anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community

Works fine ! Thankyou

  • AJV009 authored 521dffa on 2.0.x 
    Issue #3221669 by AJV009, Anjali Rathod: Create 'Node Type' filter
harivenuv’s picture

harivenuv
Location India
commented

Thanks you @AJV009 and @Anjali Rathod, Patch looks fine and I have merged.

harivenuv’s picture

harivenuv
Location India
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.