Problem/Motivation

When selecting a pdf file, the thumbnail icon cannot be displayed

Steps to reproduce

1.click file upload button in ckeditor
2.select a pdf file in file listing or upload a new pdf file
3.the thumbnail icon cannot be displayed as shown in the attached picture

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3221662_add_pdf_thumbnail.patch822 bytesfranckylfs
#3 3221662-add_thumbnails_when_select_a_pdf_file.patch758 bytesconnbi
#2 3221662-add_thumbnails_when_select_a_pdf_file.patch731 bytesconnbi
image-2021-07-01-11-30-38-733.png125.06 KBconnbi
image-2021-07-01-11-35-48-926.png174.12 KBconnbi

Issue fork file_browser-3221662

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bijiaxing created an issue. See original summary.

connbi’s picture

connbi commented
StatusFileSize
new 3221662-add_thumbnails_when_select_a_pdf_file.patch731 bytes
connbi’s picture

connbi commented
StatusFileSize
new 3221662-add_thumbnails_when_select_a_pdf_file.patch758 bytes
franckylfs’s picture

franckylfs commented
StatusFileSize
new 3221662_add_pdf_thumbnail.patch822 bytes

The patch didn't work for me. So, I looked at the code and made a slight adjustment during validation. Now it works. Here is my version of the patch.

d.fisher’s picture

d.fisher commented
Title: add thumbnails when select a pdf file » Add thumbnails when selecting a pdf file
Version: 8.x-1.3 » 2.x-dev
Assigned: connbi » d.fisher
Status: Active » Needs work

Let's get this rolled into a branch with a merge request!

d.fisher opened merge request !13

d.fisher’s picture

d.fisher commented
Assigned: d.fisher » Unassigned
Status: Needs work » Needs review

Branch and MR now pass gitlab pipelines.

@connbi and @franckylfs can you test MR!13 against the 2.x branch and see if it resolves the issue for you?

You can add the patch to your composer patches using the MR url:
https://git.drupalcode.org/project/file_browser/-/merge_requests/13

and add .patch as a suffix to it like so:
https://git.drupalcode.org/project/file_browser/-/merge_requests/13.patch

This will give you a remote patch to test with. Let me know if it's working for you and when we get a couple of thumbs up we can get this merged and released and marked as fixed with you both credited for you hard work.

Thank you!

d.fisher’s picture

d.fisher commented

Anyone want to review this one and mark as RTBC if it solves the issue?

d.fisher’s picture

d.fisher commented
Status: Needs review » Reviewed & tested by the community

Marking RTBC based on my own testing. No objections reported here so going to get this one moving.

d.fisher’s picture

d.fisher commented
Status: Reviewed & tested by the community » Fixed

Merged to 2.x and will be in next tagged release.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • d.fisher committed 010a10e6 on 2.x 
    Resolve #3221662 "Add thumbnails when selecting a pdf file"

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.