Values input mode with Set of Values not working with "0"

#2 didn't fix the issue on my setup.

Re-roll of the patch #4.

I reviewed the patch, so it's enough to validate 0.
moving status for RTBC

+++ b/src/ConditionalFieldsFormHelper.php
@@ -154,7 +154,7 @@ class ConditionalFieldsFormHelper {
+      if ((!empty($options['values']) || $options['values'] == "0") && is_string($options['values'])) {

Because we're duplicating this code in a few places, which is a terrible idea, let's move it to a method like notEmpty(), and then call it from each location.

@colan I'll take a look at this

I ran a search with the regex !empty\([\s\S]*\) \|\| [\s\S]* == "0" to check how many times the code !empty($options['values']) || $options['values'] == "0" or similar appeared on the module files. It appears three times, once in src/ConditionalFieldsFormHelper.php and twice in src/Form/ConditionalFieldEditForm.php. Because it only appears more than once inside ConditionalFieldEditForm.php I created the new function there and left ConditionalFieldsFormHelper.php untouched.

But if the intention was to replace all three instances with the notEmpty function then a Trait may be a better approach. (So I created a second patch using a trait, just in case).

Hi I revised and applied the patch #17 and when we set the value 0 on the "Set of values" is working now and then the issue was resolved.

I'm going to change the issue's status for RTBC.

But I think it's better the maintainer to chose if he will to commit the patch with or without traits.

This needs another review and further discussion since some years are gone and the previously discussed things have been partly adressed and new questions have raised around them. So new thoughts are welcome.