As discovered in #3221220-4: Fix coding standards for Coder 8.3.13 it seems that the drupal.org testbot process is different when running a Merge Request branch compared to an ordinary patch test or regular branch test.

The failures are due to invalid permissions in the RulesTest and DateModuleTest which leads me to suspect it is something to do with the required modules not being loaded. This needs to be fixed separately, first, before we can use the MR branches for proper work.

Issue fork scheduler-3221289

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !7

jonathan1055’s picture

jonathan1055 commented

Here is a trivial change to README.txt with nothing else, to a baseline on how MR testing behaves with core 7.x

[edit]
That's good, we get the same faults as in #3221220: Fix coding standards for Coder 8.3.13

jonathan1055’s picture

jonathan1055 commented

In scheduler.info we have

test_dependencies[] = date
test_dependencies[] = rules

but these modules do not appear to be loaded. Maybe the MR branch expects a composer.json file which is will use to get the dependencies, and does not read the .info file. Hence adding a composer.json file with

    "require-dev": {
        "drupal/date": "*",
        "drupal/rules": "*"
    },

just to see what happens

jonathan1055’s picture

jonathan1055 commented

So that is good. The tests run and pass properly now that we have a composer.json file.

There is no phpcs output because by default only modified files are checked. Just for info, here is a drupalci.yml file with 

      phpcs:
        sniff-all-files: true
jonathan1055’s picture

jonathan1055 commented

All good. New drupalci.yml and comopser.json files will be committed.

  • jonathan1055 committed ab1944f on 7.x-1.x 
    Issue #3221289 by jonathan1055: Tests fail at 7.x when run on Merge...
jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

Nice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 commented
Title: Tests fail at 7.x when run on Merge Request branch » MR tests fail at 7.x - need composer.json and drupalci.yml

Changed title to better reflect the solution.