7.x tests running PHP5.3 use drupal/coder version 8.2.5, and at PHP5.5 it is coder 8.3.7. All of these tests are clean.

However, tests at PHP7.1+ used Coder 8.3.13 and we now get new coding standards faults

FILE: /Library/WebServer/Web/dr-source/modules-D7-git/scheduler/plugins/content_types/scheduler_form_pane.inc
------------------------------------------------------------------------------------------
 10 | WARNING | Unused variable $plugin. (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
------------------------------------------------------------------------------------------

FILE: /Library/WebServer/Web/dr-source/modules-D7-git/scheduler/scheduler.module
------------------------------------------------------------------------------------------
 879 | WARNING | Exceptions should not be translated
     |         | (DrupalPractice.General.ExceptionT.ExceptionT)
------------------------------------------------------------------------------------------

FILE: /Library/WebServer/Web/dr-source/modules-D7-git/scheduler/tests/scheduler.test
------------------------------------------------------------------------------------------
  909 | WARNING | [x] '@TODO Add tests when scheduled publishing and unpublishing are
      |         |      required.' should match the format '@todo Fix problem X here.'
      |         |     (Drupal.Commenting.TodoComment.TodoFormat)

and lots of the form

------------------------------------------------------------------------------------------
   32 | ERROR   | [ ] The array declaration extends to column 85 (the limit is 80). The
      |         |     array content should be split up over multiple lines
      |         |     (Drupal.Arrays.Array.LongLineDeclaration)

Summary of all errors

PHP CODE SNIFFER REPORT SUMMARY
------------------------------------------------------------------------------------------
FILE                                                                      ERRORS  WARNINGS
------------------------------------------------------------------------------------------
.../WebServer/Web/dr-source/modules-D7-git/scheduler/scheduler.admin.inc  5       0
...y/WebServer/Web/dr-source/modules-D7-git/scheduler/scheduler.cron.inc  2       0
...ary/WebServer/Web/dr-source/modules-D7-git/scheduler/scheduler.module  1       1
...r/Web/dr-source/modules-D7-git/scheduler/scheduler.rules_defaults.inc  2       0
...WebServer/Web/dr-source/modules-D7-git/scheduler/tests/scheduler.test  20      0
...erver/Web/dr-source/modules-D7-git/scheduler/tests/scheduler_dev.test  1       0
------------------------------------------------------------------------------------------
A TOTAL OF 31 ERRORS AND 1 WARNING WERE FOUND IN 6 FILES
------------------------------------------------------------------------------------------

Issue fork scheduler-3221220

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added summary

jonathan1055 opened merge request !6

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

That's interesting and unexpected. The changes were only "cosmetic" for coding standards, yet the build at PHP5.6 fatally crashes, and at PHP7.3 we get test failures. Both of these pass OK on normal patch testing and regular branch testing. So does the process of testing via pushes to a MR branch run a different testing process?

In Scheduler.SchedulerDateModuleTest testDefaultTime

testDefaultTime
fail: [Completion check] Line 1091 of sites/all/modules/scheduler/tests/scheduler.test:
The test did not complete due to a fatal error.

setUp
fail: [Other] Line 1084 of sites/all/modules/scheduler/tests/scheduler.test:
Enabled modules: date, date_popup, scheduler

commonSettings
fail: [Role] Line 40 of sites/all/modules/scheduler/tests/scheduler.test:
Invalid permission administer scheduler.

in Scheduler.SchedulerRulesTest testRulesActions

fail: [Role] Line 40 of sites/all/modules/scheduler/tests/scheduler.test:
Invalid permission view scheduled content.

But at least the intended coding standards fixes were successful.

8 coding standards messages
✓ 14 fewer than branch result
jonathan1055’s picture

jonathan1055 commented

Now that #3221289: MR tests fail at 7.x - need composer.json and drupalci.yml is committed this MR should run OK.

  • jonathan1055 committed dfe7dfd on 7.x-1.x 
    Issue #3221220 by jonathan1055: Fix coding standards for Coder 8.3.13
jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

Committed and fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.