Support for Empty Fields and other third party formatter settings. [#3220671]

Problem/Motivation

In scenarios where the entity has been populated and the data for a field is presented read-only in the form, it could be useful to allow for configurable empty text on the widget configuration.

In an example scenario, we are populating entities through Migrate. Those entities will then be reviewed in edit mode, where some data is allowed to be modified directly, and in other cases we display the migrated data as read-only and ask the person reviewing the entity if that data is correct. In instances where no data was migrated for a field it would be useful to display a message such as "This field is empty." or "No data present", etc.

Comment	File	Size	Author
#14	readonly_field_widget-third-party-settings-3220671-mr-1-reroll.patch	8.77 KB	rigoucr
#12	readonly_field_widget-empty-text-2.1.0-reroll.patch	2.38 KB	rigoucr
#8	third-party-settings-3220671-8.patch	7.59 KB	pookmish
#6	third-party-settings-3220671-6.patch	7.83 KB	thtas

Issue fork readonly_field_widget-3220671

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3220671-third-party-settings changes, plain diff MR !5
Check out this branch for the first time

Check out existing branch, if you already have it locally

2 hidden branches

8.x-1.x

changes, plain diff MR !1

Check out this branch for the first time

Check out existing branch, if you already have it locally

3220671-empty-text

compare

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

24 June 2021 at 18:47

jerdavis created an issue. See original summary.

Comment #2

24 June 2021 at 19:06

jerdavis opened merge request !1

Comment #3

thtas commented 25 June 2021 at 00:18

Perhaps this will work in conjunction with the https://www.drupal.org/project/empty_fields module?

Comment #4

jerdavis

Minneapolis, MN

commented 25 June 2021 at 16:04

Empty Fields works on field formatters, not field widgets. Just as I need this module to render the field widget (input) as read-only, I need it to also have functionality to display a message when that field is empty. The field formatter renders the output of the field on the view of an entity, rather than the form mode.

Comment #5

thtas commented 25 June 2021 at 23:02

This module uses the field formatters as options to display in the widget mode, so I was hoping the empty field module options might be available without too many changes to this module, but it sounds like it might need some integration work.

Comment #6

thtas commented 14 August 2022 at 12:45

Status	File	Size
new	third-party-settings-3220671-6.patch	7.83 KB

In order for this module to work with the Empty Fields module, it first needs support for field formatter third party settings.

Attached is a patch to bring in such support in a general way.

However, because of the way the Empty Fields AJAX forms make assumptions about the structure form state it will need patches or perhaps some other workaround before it will work with this module.

Todo:
- Add some test coverage to ensure that third party settings work as expected in a simple example (partially done)
- Investigate patching Empty Fields so that their third party settings ajax forms work with the patch attached here.