Problem/Motivation

There already have been some issues regarding the rules integration. This ticket is about moving the rules module into a submodule.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 3220608-11.patch6.77 KBduivw
#10 3220608-10.patch8.39 KBcasey
#9 3220608-remove-rules-quiz7.x.patch8.41 KBsocialnicheguru
#6 3220608-6.patch9.21 KBtimohuisman
#5 3220608-5.patch8.87 KBtimohuisman
#2 3220608-2.patch8.31 KBcasey

Issue fork quiz-3220608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

casey created an issue. See original summary.

casey’s picture

casey commented
StatusFileSize
new 3220608-2.patch8.31 KB

This patch removes all rules integration replacing it with a simple replacement to investigate how deep te integration goes.

timohuisman made their first commit to this issue’s fork.

timohuisman opened merge request !12

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
StatusFileSize
new 3220608-5.patch8.87 KB

Rerolled #2 and opened an issue fork. Added a patch for the current state of the merge request, because we don't like to use a moving target in our projects.

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
StatusFileSize
new 3220608-6.patch9.21 KB

Updated the MR with the latest changes from 6.x. Added a patch for the current state of the MR, see https://github.com/cweagans/composer-patches/issues/347 for more information.

smustgrave’s picture

smustgrave commented

From what I can tell the rules stuff has just been deleted but not moved, where's the sub-module?

smustgrave’s picture

smustgrave commented
Version: 6.x-dev » 7.0.x-dev
socialnicheguru’s picture

socialnicheguru commented
StatusFileSize
new 3220608-remove-rules-quiz7.x.patch8.41 KB

reroll just to remove rules from Quiz 7.0.x-dev

casey’s picture

casey commented
StatusFileSize
new 3220608-10.patch8.39 KB

@smustgrave, that's right. We just don't want the dependency upon the rules module. I suggested the sub-module as I understand others might still want to use it. I don't think a hard dependency is necessary.

Currently I don't have the time to work on converting the dependency into a sub-module.

Attached patch is a reroll for quiz 6.0.x-dev.

duivw’s picture

duivw commented
StatusFileSize
new 3220608-11.patch6.77 KB

Rerolled #10 against 7.0.x. for D11 compatibility.

smustgrave closed merge request !12

socialnicheguru’s picture

socialnicheguru commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Fixes should be in MRs please

smustgrave’s picture

smustgrave commented
Priority: Normal » Major

Almost wanted to say critical. Rules may be broken 11.3 thus quiz is now too

timohuisman opened merge request !63

timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
Status: Needs work » Needs review

I've created MR!63, which basically is the patch from #11.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Thanks but appears to have pipeline issues, some of the phpstan is known but appears this change introduced more. Also broke the tests.

smustgrave’s picture

smustgrave commented

Also seems to just be removing rules not moving to a sub-module.

smustgrave opened merge request !64

smustgrave closed merge request !63

smustgrave’s picture

smustgrave commented
Version: 7.0.x-dev » 8.0.x-dev
smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

  • smustgrave committed 407131fe on 8.0.x 
    feat: #3220608 Move rules integration into a sub module
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Have a client project that may need this so went ahead and merged. Ping me if any issues!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.