Improve the confirmation form question for translatability

Since we're already in "context", and especially when combined with the modal (introduced in #3220573: Add option to display confirmation form in a modal to the formatter), I'm thinking omitting the entity label could be fine... (i.e Are you sure you want to "Place order"?).

Regarding your suggestions, we could also do:

"Are you sure you want to move [My cool node title] from [draft] to [published]?"

When recording state transitions for orders, commerce_log defines this template:
"Order moved from <em>{{ from_state }}</em> to <em>{{ to_state }}</em> by the <em>{{ transition_label }}</em> transition."

Additionally, there's one alternative option we haven't explored yet which is to update the description text, which currently simply says "This action cannot be undone".

The description could say something like the following instead:

Clicking on '%transition_label' will move the %entity_label from %from_state to %to_state. This action cannot be undone.

Though if we go this route, it'll also be complex to find a description text that fits for all entity types / transitions.

Great feedback! I see a problem even in the use of the word "to" in the sentence, because in English, "to" is what signifies an infinitive (e.g. "to place"), while other languages just use a different case ... meaning "place" itself would be morphed to represent the infinitive, even though in the original context "place" is an imperative. Practically speaking, I think it will be impossible to have a "correct" sentence that's meaningfully translatable.

So ... I actually really like Jonathan's suggestion as an elegant workaround that trades out a "nice" full sentence for having a simple question ("Are you sure you want to apply this transition?") with technical details. It may not be as user-friendly to the merchant, but it'll be absolutely clear.

My proposal would essentially be:

Are you sure you want to apply this transition?

Transition: [transition label]
[Entity type]: [entity label]
From: [from state label]
To: [to state label]

(I'm just not sure if we need to bold the items on the left or not ... may be necessary for readability.)

The attached patch implements the proposal from #3.

If we all come to an agreement, we can commit this, tag a new release so Commerce can require State machine 1.4 and benefit from the modals in the next version that's planned for tomorrow (2.25).

Tried 2 different versions:

Using a list:

Using a regular paragraph (option chosen):

Thoughts?

Fixed phpcs violations.

As a side note, it feels a bit weird to not get a confirmation message... But that's another issue that we can probably address later.

1. +++ b/src/Form/StateTransitionConfirmForm.php
   @@ -24,6 +32,15 @@ class StateTransitionConfirmForm extends ContentEntityConfirmFormBase {
   +  /**
   +   * {@inheritdoc}
   +   */
   +  public static function create(ContainerInterface $container) {
   +    $instance = parent::create($container);
   +    $instance->renderer = $container->get('renderer');
   +    return $instance;
   +  }
   

   You can do this on a protected method? You need a setter method for the property.

2. +++ b/src/Form/StateTransitionConfirmForm.php
   @@ -46,18 +63,36 @@ class StateTransitionConfirmForm extends ContentEntityConfirmFormBase {
   +    return $this->renderer->render($description);
   

   You should use `renderPlain` here to avoid leaked cache data.

You can do this on a protected method? You need a setter method for the property.

Yes, and core does that in multiple places.

You should use `renderPlain` here to avoid leaked cache data.

Done!

+1 looks good to me.

Committed! Thanks everyone!