Closed (fixed)
Project:
Commerce Shipping
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Jun 2021 at 07:33 UTC
Updated:
14 Jul 2021 at 11:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jsacksick commentedI'm expecting some tests to fail... But in any case, the attached patch cannot be committed as is... Unless we define our own state transition form (which might be necessary to fix the question that looks a bit ugly)... or we wait for a State machine release to be tagged to include the fix from #3220111: Url route parameters should be merged when redirecting to the confirmation form, otherwise the redirect to the confirmation form crashes due to the missing "commerce_order" parameter.
Comment #4
jsacksick commentedWe need to fix the question (i.e defining our own state transition form and extend
getQuestion()but not sure what the question template should be...The "question" currently says: "Are you sure you want to finalize shipment Shipment #1?"
Wondering if we shouldn't at least, add quotes around the shipment label 'Are you sure you want to finalize shipment "Shipment #1?"'..
Tests should pass now though.
Comment #5
neograph734I noticed you already tagged a new state machine release, but I ran into that same issue during translating to Dutch; the order of words is different then. So perhaps better to still fix that in state machine?
The closest I got in the translation was something like "are you sure you want to apply transition 'x' to 'entity label y'?"
Sorry for insisting differently earlier... :(
Comment #6
jsacksick commentedWell, whatever we come up with, I don't think we'll find a template that works correctly for all entity types.
I tagged a State machine release because a Commerce release is planned for next wednesday, could have waited a few more days, but wanted to start refactoring commerce_shipping etc.
In any event, this can be altered via code, and the confirmation can be disabled still... So I don't believe we'd need to rush yet another State machine release.
Comment #7
neograph734I understand and agree with you. I will file the issue in state machine for later though.
Comment #8
jsacksick commentedComment #10
jsacksick commentedComment #11
jsacksick commentedTests are green, committing!