Problem/Motivation

When running unit tests in PHP 8 the following error is thrown:

TypeError : uasort(): Argument #1 ($array) must be of type array, null given

Seems to be due to #3115987: Rename the $instanceIDs property used from plugin classes to $instanceIds.

Steps to reproduce

Run unit tests on PHP 8

Proposed resolution

Update reference to variable

Remaining tasks

  • Review patch
  • Run weekly PHP 8 tests

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#2 ctools-3220480-1-instance-ids.patch541 bytesmstrelan

Comments

mstrelan created an issue. See original summary.

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
StatusFileSize
new ctools-3220480-1-instance-ids.patch541 bytes
acbramley’s picture

acbramley commented
Status: Needs review » Reviewed & tested by the community

Easy peasy! Search the codebase and this is the only place that casing is used.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks for spotting this, I've committed it to dev.

  • joelpittet committed 55ff02c on 8.x-3.x authored by mstrelan 
    Issue #3220480 by mstrelan, acbramley: [PHP8] TypeError : uasort():...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hockey2112’s picture

hockey2112 commented

This fixed a similar issue with Viewfield: https://www.drupal.org/project/viewfield/issues/3381787#comment-15199519