Problem/Motivation

Currently the 8.x-3.x-dev branch has 10 Coding Standard messages.

10 coding standards messages
	
auto_entitylabel.module
line 24	The array declaration line has 506 characters (the limit is 80). The array content should be split up over multiple lines
src/Batch/ResaveBatch.php
18	Doc comment short description must start with a capital letter
18	Doc comment short description must end with a full stop
48	Doc comment short description must start with a capital letter
48	Doc comment short description must end with a full stop
src/Form/AutoEntityLabelForm.php
17	The class short comment should describe what the class does and not simply repeat the class name
287	The array declaration line has 91 characters (the limit is 80). The array content should be split up over multiple lines
308	Missing function doc comment
326	A comma should follow the last multiline array item. Found: $operations
332	Missing function doc comment

Steps to reproduce

See: https://www.drupal.org/pift-ci-job/1989001

Proposed resolution

Fix 'em all!

Remaining tasks

  • Create Patch/MR
  • Review
  • Commit
  • Rejoice
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Issue summary: View changes

spokje’s picture

Issue summary: View changes
Status: Active » Needs review

Looking at the result of PHPCS on the latest test (on commit) of this branch here and the result of the test on this MR here, which is empty, so no errors to output, I'm confident enought to put this issue on Needs Review.

spokje’s picture

Assigned: spokje » Unassigned
renatog’s picture

Status: Needs review » Reviewed & tested by the community

@Spokje your MR is doing a great job. Adding coding standards fixes. Thanks a lot for you effort on that. +1 to RTBC

  • RenatoG committed 8c19657 on 8.x-3.x authored by Spokje
    Issue #3220398 by Spokje, RenatoG: Fix Coding Standard Messages
    
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Moved to the dev branch.

Thank you so much for that

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.