Problem/Motivation
Currently the 8.x-3.x-dev branch has 10 Coding Standard messages.
10 coding standards messages
auto_entitylabel.module
line 24 The array declaration line has 506 characters (the limit is 80). The array content should be split up over multiple lines
src/Batch/ResaveBatch.php
18 Doc comment short description must start with a capital letter
18 Doc comment short description must end with a full stop
48 Doc comment short description must start with a capital letter
48 Doc comment short description must end with a full stop
src/Form/AutoEntityLabelForm.php
17 The class short comment should describe what the class does and not simply repeat the class name
287 The array declaration line has 91 characters (the limit is 80). The array content should be split up over multiple lines
308 Missing function doc comment
326 A comma should follow the last multiline array item. Found: $operations
332 Missing function doc comment
Steps to reproduce
See: https://www.drupal.org/pift-ci-job/1989001
Proposed resolution
Fix 'em all!
Remaining tasks
Create Patch/MR- Review
- Commit
- Rejoice
Issue fork auto_entitylabel-3220398
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
spokjeComment #4
spokjeLooking at the result of PHPCS on the latest test (on commit) of this branch here and the result of the test on this MR here, which is empty, so no errors to output, I'm confident enought to put this issue on
Needs Review.Comment #5
spokjeComment #6
renatog commented@Spokje your MR is doing a great job. Adding coding standards fixes. Thanks a lot for you effort on that. +1 to RTBC
Comment #8
renatog commentedMoved to the dev branch.
Thank you so much for that