Problem/Motivation

In module listing page not able to find the configure link for this module.

Steps to reproduce

Download and install the module, visit extends page you find no link to configure this module.

Proposed resolution

Adding the configure attribute in info.yml

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 site_3220018-5.png51.91 KBkleiton_rodrigues
#5 3220018-5.png82.23 KBkleiton_rodrigues
#4 toastr_after_patch.png14.16 KBankithashetty
#4 toastr_before_patch.png10.88 KBankithashetty
#2 3220018-missing-configure-2.patch265 bytessanthosh-kumar-rengasamy

Comments

Santhosh-Kumar-Rengasamy created an issue. See original summary.

santhosh-kumar-rengasamy’s picture

santhosh-kumar-rengasamy commented
StatusFileSize
new 3220018-missing-configure-2.patch265 bytes

This patch will introduce the configure link in the module listing page.
Please review.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Active » Needs review
ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Assigned: santhosh-kumar-rengasamy » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new toastr_before_patch.png10.88 KB
new toastr_after_patch.png14.16 KB

The patch in #2 looks good to me.

Patch applied successfully:

$ git apply 3220018-2.patch -v
Checking patch toastr.info.yml...
Applied patch toastr.info.yml cleanly.

Screenshot before applying the patch:
On visiting the Extends page, the configure link doesn't appear under Toastr module before appyling the patch.

Screenshot after applying the patch:
On visiting the Extends page, a configure link appears under Toastr module after applying the patch. On click of configure, user will be redirected to Toastr message settings page (/admin/config/system/toastr).

Changing status to RTBC.

kleiton_rodrigues’s picture

kleiton_rodrigues commented
StatusFileSize
new 3220018-5.png82.23 KB
new site_3220018-5.png51.91 KB

Patch #2 is working correctly.
RTBC +1

kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: kleiton_rodrigues » Unassigned
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Let's get this in

omkar-pd’s picture

omkar-pd commented
Status: Reviewed & tested by the community » Fixed

Committed, Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.