Problem/Motivation

Seeing same log error as https://www.drupal.org/project/miniorange_saml/issues/3052899 - "headers have already been sent" but with this module at version 2.22 (and also 2.21) with Drupal Core 9.2

Steps to reproduce

Try to log in. Salesforce side works, but not logged in on drupal side.

Proposed resolution

check what could need fixing for 9.2 / test with 9.2

Remaining tasks

as above

User interface changes

this is under the bonnet - no ui changes expected

API changes

dont know - could be with respect to SAML, or interfaces to Drupal Core 9.2

Data model changes

dont know

Comments

therobyouknow created an issue. See original summary.

therobyouknow’s picture

therobyouknow commented
Title: compatible with Drupal Core 9.2 ? "headers have already been sent" » compatible with Drupal Core 9.2 ? Log Error: "headers have already been sent"
pc_freelance’s picture

pc_freelance commented

Same issue.
@therobyouknow have you find a temporary fix ?

arsh244’s picture

arsh244 commented

Hi @therobyouknow & @pc_freelance, we have fixed the issue in the latest version of the module i.e. 8.x-2.23. Please test the module and let me know in case you face any issues.

therobyouknow’s picture

therobyouknow commented

Thank you arsh244 we will try it and follow up.

pc_freelance, before arsh244's announced fix, our work around was to downgrade code to 9.1 from 9.2 which got the login with salesforce working again. We downgraded just code, not reverting any core or otherwise database updates associated with 9.2. Ideally we'd have wanted to also do that for consistency of code and db but the downgraded site appears to be working OK. There's not a general process for downgrading database updates as far as I know and we were fortunate that the site code downgrade sufficed.

I'm pleased to hear about this fix announced by arsh244 because that would be the ultimate solution. because 9.2 and beyond will become the main 9 version eventually of course.

We need to setup an instance of salesforce or equivalent non live setup on our staging site to test the fix before rolling out to live.

Thanks again arsh244.

gauravsood91’s picture

gauravsood91 commented
Status: Active » Fixed

arsh244, I have tested the module with 9.2 and it seems to be working fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sadikyalcin’s picture

sadikyalcin commented

Future visitors; you might come across this issue if your site is running on HTTP.