Problem/Motivation

Limit this to one line easy fixes, avoid any possible controversy, or any change that would better fit with other words, such as doing chien and chiens in the same patch.

The list of words beginning with q -> s, inclusive, that are used once in one file and the name of the file.

Proposed resolution

Exclude words covered in #3210125: Fix spelling in core.* yml files

Remove the following from dictionary.txt
1 -querystrings
2 -rawurlencoding
3 -reimplementing
4 -reinitializes
5 -rescan
6 -reuploading
7 -robo
8 -routename
9 -rowtest
10 -rrggbb
11 -rxpq
12 -safed
13 -sapere
14 -scaffol
15 -screenreader
16 -searchpages
17 -shortnames
18 -someclass
19 -somefile
20 -sometext
21 -soofy
22 -startpunt
23 -stringis
24 -subpatterns

Remaining tasks

Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes
StatusFileSize
new21.71 KB
quietone’s picture

StatusFileSize
new579 bytes
new21.99 KB

A coding standard error on lines not changed in this patch is unexpected.

quietone’s picture

Status: Active » Needs review
quietone’s picture

Assigned: quietone » Unassigned

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll
murilohp’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new21.68 KB
new11.3 KB

Hey I made the reroll of #3 to branch 9.4.

Thanks!

quietone’s picture

StatusFileSize
new794 bytes
new22.39 KB

@murilohp, thanks for the reroll.

+++ b/core/misc/cspell/dictionary.txt
@@ -1285,16 +1268,13 @@ sloopal
+somefieldname

Not sure why this is being added. I grepped core and this is the only instance found.

I applied the patch, removed 'somefieldname' from the dictionary and ran yarn run spellcheck:core . That gave an error on on 'startpunt'. This patch fixes that and removes 'somefieldname' from the dictionary.

quietone’s picture

Issue summary: View changes
StatusFileSize
new3.33 KB
new22.4 KB

Another reroll.

longwave’s picture

Status: Needs review » Needs work

This looks close but a couple of nitpicks:

  1. +++ b/core/modules/system/src/Plugin/ImageToolkit/GDToolkit.php
    @@ -15,6 +15,8 @@
    +// cspell:ignore rrggbb
    
    @@ -293,7 +295,7 @@ public function parseFile() {
    -   *   A color string like '#rrggbb', or NULL if not set or not relevant.
    +   *   A color string like '#', or NULL if not set or not relevant.
    

    We add an ignore for 'rrggbb' but then remove it from the comment, I think it should stay in the comment for it to make sense.

  2. +++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_user_path.yml
    @@ -56,7 +56,7 @@ display:
    -            offset_label: Startpunt
    +            offset_label: 'Start punt'
    

    "Startpunt" is Dutch, this is better translated as "Starting point" I think.

murilohp’s picture

Status: Needs work » Needs review
StatusFileSize
new22 KB
new1.29 KB

Thanks for the review @longwave, here's a new patch addressing the changes.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks - this all looks good to me now.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 76c0ec2 and pushed to 10.0.x. Thanks!
Committed e4d7e07 and pushed to 9.4.x. Thanks!

+++ b/core/modules/block/tests/src/Unit/Plugin/migrate/process/BlockVisibilityTest.php
@@ -57,10 +57,10 @@ public function testTransformSinglePageWithFront() {
-    $visibility = $this->plugin->transform([1, "foo\n/bar\rbaz\r\n<front>", []], $this->migrateExecutable, $this->row, 'destination_property');
+    $visibility = $this->plugin->transform([1, "foo\n/bar\rBaz\r\n<front>", []], $this->migrateExecutable, $this->row, 'destination_property');
     $this->assertSame('request_path', $visibility['request_path']['id']);
     $this->assertFalse($visibility['request_path']['negate']);
-    $this->assertSame("/foo\n/bar\n/baz\n<front>", $visibility['request_path']['pages']);
+    $this->assertSame("/foo\n/bar\n/Baz\n<front>", $visibility['request_path']['pages']);

I'm not sure these changes are necessary anymore - rbaz is no longer in the dictionary. Removed on commit after re-running spell checking.

  • alexpott committed 76c0ec2 on 10.0.x
    Issue #3219649 by quietone, murilohp, longwave: Fix spelling for words...

  • alexpott committed e4d7e07 on 9.4.x
    Issue #3219649 by quietone, murilohp, longwave: Fix spelling for words...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.