Problem/Motivation
Limit this to one line easy fixes, avoid any possible controversy, or any change that would better fit with other words, such as doing chien and chiens in the same patch.
Proposed resolution
Exclude words covered in #3210125: Fix spelling in core.* yml files
Remove the following from dictionary.txt
1 -querystrings
2 -rawurlencoding
3 -reimplementing
4 -reinitializes
5 -rescan
6 -reuploading
7 -robo
8 -routename
9 -rowtest
10 -rrggbb
11 -rxpq
12 -safed
13 -sapere
14 -scaffol
15 -screenreader
16 -searchpages
17 -shortnames
18 -someclass
19 -somefile
20 -sometext
21 -soofy
22 -startpunt
23 -stringis
24 -subpatterns
Remaining tasks
Review
Commit
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | interdiff_10-12.txt | 1.29 KB | murilohp |
| #12 | 3219649-12.patch | 22 KB | murilohp |
| #10 | 3219649-10.patch | 22.4 KB | quietone |
| #10 | diff-9-10.txt | 3.33 KB | quietone |
| #9 | 3219649-9.patch | 22.39 KB | quietone |
Comments
Comment #2
quietone commentedComment #3
quietone commentedA coding standard error on lines not changed in this patch is unexpected.
Comment #4
quietone commentedComment #5
quietone commentedComment #7
longwaveComment #8
murilohp commentedHey I made the reroll of #3 to branch 9.4.
Thanks!
Comment #9
quietone commented@murilohp, thanks for the reroll.
Not sure why this is being added. I grepped core and this is the only instance found.
I applied the patch, removed 'somefieldname' from the dictionary and ran
yarn run spellcheck:core. That gave an error on on 'startpunt'. This patch fixes that and removes 'somefieldname' from the dictionary.Comment #10
quietone commentedAnother reroll.
Comment #11
longwaveThis looks close but a couple of nitpicks:
We add an ignore for 'rrggbb' but then remove it from the comment, I think it should stay in the comment for it to make sense.
"Startpunt" is Dutch, this is better translated as "Starting point" I think.
Comment #12
murilohp commentedThanks for the review @longwave, here's a new patch addressing the changes.
Comment #13
longwaveThanks - this all looks good to me now.
Comment #14
alexpottCommitted 76c0ec2 and pushed to 10.0.x. Thanks!
Committed e4d7e07 and pushed to 9.4.x. Thanks!
I'm not sure these changes are necessary anymore - rbaz is no longer in the dictionary. Removed on commit after re-running spell checking.