Problem/Motivation

@larowlan suggested in #2359675: File field's Maximum upload size always passes validation to write a test case for when the validation of the maximum upload size of a field is '300 0'.
This validation must return FALSE

Proposed resolution

Add ['300 0', FALSE], to public function providerTestValidate()

CommentFileSizeAuthor
#3 3218711-2.patch497 bytespaulocs

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
StatusFileSize
new 3218711-2.patch497 bytes
guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community

Seems simple enough, works as intended. Moving to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3218711-2.patch, failed testing. View results

guilhermevp’s picture

guilhermevp commented

Test fail is unrelated to the patch, just retesting to be sure, if it passes, back to RTBC.

guilhermevp’s picture

guilhermevp commented
Status: Needs work » Reviewed & tested by the community

Moving back!

alexpott credited larowlan.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c1c5f34 and pushed to 9.3.x. Thanks!

  • alexpott committed c1c5f34 on 9.3.x 
    Issue #3218711 by paulocs, larowlan: Add a test case for when Maximum...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.