8.x-1.2 worked with 8.9.15 as expected. However the newest version stops showing both the checkbox and the button when editing a node.
Permissions configured as before.
(This is not about the checkbox in Structure -> Content Types described in the documentation. See https://www.drupal.org/project/publishcontent/issues/2996216 for details on that documentation issue.)
Another user can also reproduce this issue: https://www.drupal.org/project/publishcontent/issues/2996216#comment-141...
No debug log entries whatsoever..
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | no-checkbox-or-button-3218091.patch | 596 bytes | ashrafomar |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
seutje commentedSame issue here, checkbox disappeared after updating Core & contrib.
Comment #3
dercheffeSame issue here. This is a major issue IMO, because this kind of behavior makes the module useless.
Edit:
On the project page is written:
There is no option like that in my D8 site content type configuration. Only in the user permission settings I can set the privileges. Is this normal or part of the bug/issue?
Comment #4
tgoeg commentedThis is normal.
The checkbox in Structure -> Content Types not being there is a separate "issue", i.e. it is a non-issue. Reading the related issue https://www.drupal.org/project/publishcontent/issues/2996216 it seems this checkbox has been there on 7.x and the documentation does not reflect that change yet.
This issue is about the module not doing anything at all, as the checkbox when editing a node is gone.
Comment #5
tgoeg commentedComment #6
tgoeg commentedAs these two issues both lead to the same problem, they seem to be hard to tell apart. I tried to clarify with a topic update.
Comment #7
dercheffeThanks @tgoeg for clarifying.
This I can confirm too.
Comment #8
dercheffeAfter some further testing, I can confirm, that Drupal 8.9.16 (current Drupal 8 release) and 8.x-1.2 are working in combination as expected.
Perhaps a release roll back would make sense.
Comment #9
dercheffeComment #10
dercheffeComment #11
ashrafomar commentedFirst update the settings here /admin/config/workflow/publishcontent
One of other issue is coming from the publishcontent.module file publishcontent_form_node_form_alter
line 27
(!empty($form['status']) && !isset($form['status']['#access']))this will return false since the$form['status']['#access']exit, hence the step of adding/allowing the access to publish is skippedI changed this
(!empty($form['status']) && !isset($form['status']['#access']))to(!empty($form['status']) && isset($form['status']['#access']))and everything is working as expected.
I'm not 100% sure what was the purpose of checking
$form['status']['#access']is not set, so the author will need to review this.Comment #14
rodrigoaguileraI think there was some bad logic introduced here:
https://www.drupal.org/project/publishcontent/issues/3023951
I opened a merge request to change the logic from isset to empty. Please review.
You can apply it as a patch with this URL
https://git.drupalcode.org/project/publishcontent/-/merge_requests/1.patch
With that path the checkbox should be back for users with permission. When I get some confirmation I can roll a release.
I am not sure we should worry about the button since now Drupal core only uses the checkbox.
The tab action worked fine in my testing
Comment #15
dercheffeWhat button do you mean?
The patch in #14 worked great for me thx.
Comment #16
rodrigoaguileraI read the issue title and I imagined it was referring to the button that existed in Drupal 8.3 and below before the checkbox that was a little Dropdown with two options
The change record:
https://www.drupal.org/node/2847274
I believe the module still has some code to deal with both the checkbox and the button but I am not sure if the original poster was referring to that button.
Comment #17
tgoeg commentedYes, I also did refer to the mentioned button. I did not know this hasn't worked since 8.3+ anymore. The documentation clearly seems to be outdated.
If there's still code dealing with the button, this should be removed as well if it's not used anymore.
(Though the button might be practical, as it gets you the same functionality without loading the content edit page as it seems from the screenshots in the documentation)
Comment #18
rodrigoaguileraI edited my previous comment to link to the proper Change record
https://www.drupal.org/node/2847274
That button is inside the content edit page so I guess there is some confusion around that. I will remove it from the Issue title
Comment #19
tgoeg commentedSorry. I can't seem to find this anymore, but remember having seen a button in the context menu of a node (the "pen" icon), adding an "(un)publish" option next to "edit" and "configure block" (or similar). Maybe I mixed it up with some other module.
If the button you refer to is inside the content edit page then I'd definitely say remove the functionality, the checkbox is the accepted way of performing this (as user with "administer blocks" permission), so it should be like this when granting permissions with this module as well.
Comment #20
dercheffeAFAIK the module offers two opportunities:
Depending on the building concept of the site both opportunities making sense. IMO every site builder should be able to decide what kind of opportunity fit's in better (per content type) into the site building concept.
Comment #21
jaydarnellPatch #14 seems to fix the problem.
Comment #22
dercheffePatch #14 seems to fix problem. Would vote for a new module release where this patch is included.
Comment #24
rodrigoaguileraReleased 1.4
Thanks everyone for the patience