Steps to reproduce:

  1. Create an order.
  2. View the order.
  3. Add a custom log entry in the 'comment on this order' box, including some "quote" 'symbols'.
  4. View the order and your admin comment will include the HTML entities, e.g.

example

Suggested steps:
Either do not escape these at the time the log is saved, or do not escape them at the time the log is rendered. They have been double escaped.

CommentFileSizeAuthor
#9 html-entities-appear-in-custom-notes-3217739-9.patch651 bytestkiehne
#5 html-entities-appear-in-custom-notes-3217739-5.patch550 bytesrob230
#2 example.png8.7 KBrob230

Comments

Rob230 created an issue. See original summary.

rob230’s picture

rob230 commented
Issue summary: View changes
StatusFileSize
new example.png8.7 KB
rob230’s picture

rob230 commented
Issue summary: View changes
rob230’s picture

rob230 commented
Issue summary: View changes
rob230’s picture

rob230 commented
StatusFileSize
new html-entities-appear-in-custom-notes-3217739-5.patch550 bytes

Patch which changes the template.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review

Switching to needs review to kick off tests.

Status: Needs review » Needs work

The last submitted patch, 5: html-entities-appear-in-custom-notes-3217739-5.patch, failed testing. View results

rob230’s picture

rob230 commented

I think the test is wrong. It's testing for escaped content, which is harmless.

tkiehne’s picture

tkiehne commented
StatusFileSize
new html-entities-appear-in-custom-notes-3217739-9.patch651 bytes

Re-rolled patch from latest 8.x-2.x

ivnish’s picture

ivnish
he/him
commented

Needs reroll to MR

jsacksick’s picture

jsacksick commented
Status: Needs work » Closed (won't fix)

Closing this in favor of #3559548: Stop escaping log template messages on input which is more recent.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.