Postponed (maintainer needs more info)
Project:
Views Bulk Operations (VBO)
Version:
4.4.x-dev
Component:
Core
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jun 2021 at 23:31 UTC
Updated:
5 Mar 2026 at 10:22 UTC
Jump to comment: Most recent
Comments
Comment #3
krystalcode commentedCreated an MR with always building the query before executing. Not sure if that's the correct solution for all cases and if there's any consequence if it's built twice (in the case it's built elsewhere in some cases), works for me.
Comment #4
krystalcode commentedI have narrowed this down to the case that the
batchsetting is set to FALSE. Whenbatchis set to TRUE the issue does not happen. I think that's the problem, the MR I created shouldn't be needed and might create other problems, we should find out why this happens whenbatchis set to FALSE - which I think is a legitimate case, you may want to process all items at once and not in batches.Comment #5
phthlaap commentedI have same issue, the step is:
- Step 1: Check to the checkbox Select / deselect all results
- Step 2: Select an action
- Step 3: Apply to selected items
- Step 4: The form Action will be executed on all items in the view.
- Step 5: Click Execute action
=> Batch process will start then show the error message "Call to a member function addMetaData() on string...."
Applied the patch and it is working now.
Comment #6
phthlaap commentedComment #7
graber commentedCan we check if the view has been built (
if (!$this->view->built))?BTW.. I cannot reproduce this locally now, created 100 articles using devel_generate and saved them all on a standard content view with VBO field in place of the core bulk operations field, batching off, no error.
Comment #9
liam morlandComment #10
liam morlandI ran into this as part of #3555811: Call to a member function getOffset() on null in ViewsBulkOperationsActionProcessor. The existing merge request fix applies cleanly on 4.4.x and is part of fixing the issue for me.
@Dimitris Bozelos, can you change the merge request to target 4.4.x? I have rebased the change.
Comment #11
ron collins commented@lkmorlan
This MR failed to apply against 4.3.4 and 4.4.4
Comment #12
liam morlandThe merge request branch is on 4.4.x. The merge request needs to be switched to target 4.4.x.
Comment #13
ron collins commentedHey VBO maintainers: what do you need to move the MR target to 4.4?
I'm currently needing to pin against an older 4.3 commit to use VBO.
Comment #14
liam morland@Dimitris Bozelos (krystalcode) since you made the merge request, you are able to switch what branch it targets. Please switch it to target 4.4.x. A maintainer can also make this change.
Comment #15
krystalcode commentedI have updated the MR, thanks.
Comment #16
liam morlandThanks. There is a "Rebase failed" message, but that must be a GitHub bug. The merge request is properly rebased.
Comment #17
erutan commentedI have been using this along with https://www.drupal.org/project/views_bulk_operations/issues/3555811 in 4.4.4 with no issues.
Comment #18
graber commented#7 needs to be addressed before this gets a RTBC.
I'm sure there are no issues with the patch but seemed to me there are no issues without the patch as well.
Comment #19
liam morlandI have addressed #7.
Comment #20
graber commented@liam, your check should always evaluate to FALSE, check line 199. If I’m not missing anything. Could you reproduce the issue?
Comment #21
liam morlandI have seen this before; see #10. I did not get setup to see this problem yesterday when I wrote #19. I was addressing #7 as requested in #18.
Comment #22
graber commentedSorry, I don't have enough time sometimes.. maybe if the project had at least minimal funding.
The base question here is: can we have any steps to reproduce the issue? In #7 I said I cannot reproduce and that's the main thing to address.