Problem/Motivation

FundsTransfer form doesn't have all default validations.

Steps to reproduce

- Go to /user/funds/transfer.
- Enter username that do not exist.
- Submit form. You get "The website encountered an unexpected error".

Proposed resolution

parent::validateForm($form, $form_state); should be added to form validation.

CommentFileSizeAuthor
#6 funds_withdraw_form_validation_error_3217510_6.patch647 bytesaporie
#5 Screenshot 2021-07-06 at 3.02.05 PM.png1.48 MBriazsaid15
#2 form_validation_failing-3217510-2.patch1.75 KBaporie

Comments

rozh created an issue. See original summary.

aporie’s picture

aporie
Primary language French
commented
Status: Active » Needs review
StatusFileSize
new form_validation_failing-3217510-2.patch1.75 KB

Hi Rozh,

Thanks for reporting this issue. Was able to reproduce.

Patch attached.

  • Aporie committed 7ea8bc7 on 2.x 
    Issue #3217510 by Aporie, rozh: FundsTransfer form don't validate that...
aporie’s picture

aporie
Primary language French
commented
Status: Needs review » Fixed
riazsaid15’s picture

riazsaid15 commented
Status: Fixed » Needs work
StatusFileSize
new Screenshot 2021-07-06 at 3.02.05 PM.png1.48 MB

If payment method is not selected + withdrawal price is greater than the wallet or there is no balance. Below error comes in.

Symfony\Component\Routing\Exception\InvalidParameterException: Parameter "method" for route "commerce_funds.withdrawal_methods.edit" must match "[^/]++" ("" given) to generate a corresponding URL. in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 204 of core/lib/Drupal/Core/Routing/UrlGenerator.php).

aporie’s picture

aporie
Primary language French
commented
StatusFileSize
new funds_withdraw_form_validation_error_3217510_6.patch647 bytes

Hi riazaid,

Thanks for reporting this issue.

Patch attached.

  • Aporie committed 3e493ff on 2.x 
    Issue #3217510 by Aporie, riazsaid15, rozh: FundsTransfer form don't...
aporie’s picture

aporie
Primary language French
commented
Status: Needs work » Fixed
riazsaid15’s picture

riazsaid15 commented

It works, You're awesome. Thanks for resolving the issues quickly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.