Problem/Motivation

A crisis banner that is assigned to a specific page, is displayed on other pages too, if they are not nodes, but for example custom paths created by a module.

Steps to reproduce

Create a crisis banner, assign it to one page
Go to a path that is defined by a module, and that is not a node
The banner is displayed here also

Proposed resolution

Change the logic for banners wit page restrictions a little.

CommentFileSizeAuthor
#2 dvg-crisis_banner_visibility-3216854-2.patch1.31 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new dvg-crisis_banner_visibility-3216854-2.patch1.31 KB

This patch changes the check a little so if a restriction is set, this is also checked for pages that are not nodes. These pages can never be selected as pages to display the banner on.

Koen.Holman’s picture

Koen.Holman commented
Status: Needs review » Reviewed & tested by the community

Getest en akkoord

  • JoshaHubbers authored 8597c22 on 7.x-1.x 
    Issue #3216854 by JoshaHubbers, Koen.Holman: Crisis banner that is...
joshahubbers’s picture

joshahubbers commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.