Most of the public forms don't use ckeditor. Every time when a public form is loaded, the 188k ckeditor.js file is loaded. It could improve the speed of page load by checking if CKEDITOR is defined in js instead of adding it as dependency.

CommentFileSizeAuthor
#5 raw_diff_3216638-5.txt878 byteshmendes
#5 3216638-5.patch922 byteshmendes
#3 3216638-3-conditional-fields-ckeditor.patch920 bytesDavidz
conditional_fields_ckeditor.patch920 bytesDavidz

Issue fork conditional_fields-3216638

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Davidz created an issue. See original summary.

Davidz opened merge request !6

Davidz’s picture

Davidz commented
StatusFileSize
new 3216638-3-conditional-fields-ckeditor.patch920 bytes

Update patch with node id and comment id

3216638-3-conditional-fields-ckeditor.patch

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Version: 8.x-1.x-dev » 4.x-dev
hmendes’s picture

hmendes commented
Status: Active » Needs review
StatusFileSize
new 3216638-5.patch922 bytes
new raw_diff_3216638-5.txt878 bytes

Re-rolling patch from #3.

vikashsoni’s picture

vikashsoni commented

patch is working fine and applied cleanly

Thanks ....

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

For me it makes sense as well.
Patch looks good.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Make sense to me too!

  • hmendes authored 88e9ee2 on 4.x 
    Issue #3216638 by Davidz, hmendes: Remove ckeditor from dependencies...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heddn closed merge request !6