Problem/Motivation

Error in check requirements.
I'm getting error message:


Error message
Notice: Undefined index: download url in photoswipe_requirements() (line 32 of modules/contrib/photoswipe/photoswipe.install).

photoswipe_requirements('runtime')
call_user_func_array('photoswipe_requirements', Array) (Line: 403)
Drupal\Core\Extension\ModuleHandler->invokeAll('requirements', Array) (Line: 109)
Drupal\system\SystemManager->listRequirements() (Line: 49)
Drupal\system\Controller\SystemInfoController->status()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 706)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Steps to reproduce

1. Install dev version. 3.x;
2. Goto "/admin/reports/status" page

CommentFileSizeAuthor
#4 after.png21.45 KBmohit.bansal623
#4 before.png14.89 KBmohit.bansal623

Issue fork photoswipe-3216372

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

batkor created an issue. See original summary.

batkor’s picture

Status: Needs work » Needs review

Change

':url' => $library['download url'],

to

':url' => $library_definition['remote'],

And changes code to codeStandard in `photoswipe.api.php` file

mohit.bansal623’s picture

StatusFileSize
new14.89 KB
new21.45 KB

I have verified this on Drupal 9.1.9 version and the changes are working fine.

Attaching screenshots for before and after.

Anybody made their first commit to this issue’s fork.

anybody’s picture

Status: Needs review » Fixed

Great work @batkor - thank you! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.