Only print failing tests

Thanks, I think this is a great idea.

Personally I'd probably go for something like --failures or --fail-only instead of --no_pass.

Will take a proper look at this ASAP.

I chose “no_pass” because the test results are either pass, fail, or exception. I didn’t want anyone to be surprised if “fail-only” also printed exceptions.

Ah I see, that makes sense. I'll see what @Fabianx thinks, but I'd be happy with --no-pass or --fail-only (I don't think it's horribly unexpected for the latter to include exceptions too).

(There's already an arg called test_names which is likely why you went for underscore, but I don't think it's expected to pass test_names on the cli, and I'd prefer dashes to underscores in the arg names.)

We can tweak the arg name on commit.

A quick bit of manual testing; I added this:

drupal-7.x$ git diff modules/simpletest/tests/common.test

class FeedIconTest extends DrupalWebTestCase {
     $text = theme_feed_icon($variables);
     preg_match('/title="(.*?)"/', $text, $matches);
     $this->assertEqual($matches[1], 'Subscribe to &"'', 'theme_feed_icon() escapes reserved HTML characters.');
+    $this->assertTrue(FALSE, 'oh noes!');
+    $this->assertFalse($variables['foobar'] == 'baz', 'ruh roh');
   }

Without the new --no_pass arg:

drupal-7.x$ sudo -u www-data php scripts/run-tests.sh --verbose --class FeedIconTest

Drupal test run
---------------

Tests to be run:
 - Feed icon (FeedIconTest)

Test run started:
 Wednesday, May 26, 2021 - 11:20

Test summary
------------

Feed icon 2 passes, 1 fail, and 1 exception

Test run duration: 15 sec

Detailed test results
---------------------


---- FeedIconTest ----


Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Pass      Other      common.test       3146 FeedIconTest->testFeedIconEscaping(
    theme_feed_icon() escapes reserved HTML characters.
Fail      Other      common.test       3147 FeedIconTest->testFeedIconEscaping(
    oh noes!
Exception Notice     common.test       3148 FeedIconTest->testFeedIconEscaping(
    Undefined index: foobar
Pass      Other      common.test       3148 FeedIconTest->testFeedIconEscaping(
    ruh roh

...and with it:

drupal-7.x$ sudo -u www-data php scripts/run-tests.sh --verbose --no_pass --class FeedIconTest

Drupal test run
---------------

Tests to be run:
 - Feed icon (FeedIconTest)

Test run started:
 Wednesday, May 26, 2021 - 11:21

Test summary
------------

Feed icon 2 passes, 1 fail, and 1 exception

Test run duration: 15 sec

Detailed test results
---------------------


---- FeedIconTest ----


Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Other      common.test       3147 FeedIconTest->testFeedIconEscaping(
    oh noes!
Exception Notice     common.test       3148 FeedIconTest->testFeedIconEscaping(
    Undefined index: foobar

So LGTM!

I suppose we could emit a message if the new arg is passed without --verbose, but that's very much a nice-to-have.

RTBC + 1, let's use --fail-only as it's more descriptive and an exception is technically a failure that simpletest just chooses to display differently.

This is great; only wish we'd done it sooner!

Thanks!