Maybe it should be moved to require-dev?

"require": {
    "php": "^5.5|^7.0",
    "drupal/core": "^8.6|^9.0",
    "squizlabs/php_codesniffer": "*"
  },
  "require-dev": {
    "composer/installers": "^1.2",
    "drupal-composer/drupal-scaffold": "^2.5",
    "drupal/coder": "^8.2",
    "webflo/drupal-core-require-dev": "~8.5"
  },

Issue fork viewsreference-3215706

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

osopolar created an issue. See original summary.

mandolinrick’s picture

mandolinrick commented

I was wondering the same thing myself....

alison’s picture

alison
she/her
commented

The 2.x version of the module does not require squizlabs/php_codesniffer:
https://git.drupalcode.org/project/viewsreference/-/blob/810f1b3b9fcf61d...

So I think this issue can be closed? -- I can't find an issue or commit # where the requirement was removed, but still, I think this issue can be considered "closed/outdated." (I landed here after updating to 2.x, noticing the requirement change, and trying to find when/why the change happened, for posterity -- I'm okay giving up on that, but figured I'd post in case someone else stopped by with a similar question.)

THAT SAID, I'll let a maintainer (or the issue author) do the closing, if that's what's decided :)

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented

It was indeed removed from 2.x. I'd be ok with removing it in 1.x as well if someone would like to create an MR for it?

keshavv made their first commit to this issue’s fork.

keshavv opened merge request !33

keshavv’s picture

keshavv commented
Status: Active » Needs review

I have removed the squizlabs/php_codesniffer and created the MR.
Please review.

  • seanB committed 2ee107cd on 8.x-1.x authored by keshavv 
    Issue #3215706: Why does this module require squizlabs/php_codesniffer?
seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.