Problem/Motivation

Drupal 9 redines for version 2.22 for those who can't upgrade to version 3

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Geocoder 8.x-2.22
Scanned on Tue, 25/05/2021 - 10:55.

4 warnings found.

Geocoder 8.x-3.4+ supports Drupal 9.

modules/contrib/geocoder/geocoder.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │ │ module is compatible with Drupal 9. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/geocoder/modules/geocoder_geofield/geocoder_geofield.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8 is not compatible with │
│ manually │ │ the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/geocoder/modules/geocoder_address/geocoder_address.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8 is not compatible with │
│ manually │ │ the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/geocoder/modules/geocoder_field/geocoder_field.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8 is not compatible with │
│ manually │ │ the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

CommentFileSizeAuthor
#2 3215558-drupal9_compatibility-2.patch1.79 KBgigimaor

Issue fork geocoder-3215558

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gigimaor created an issue. See original summary.

gigimaor’s picture

gigimaor
må-or
Location Narangba/Brisbane
commented
StatusFileSize
new 3215558-drupal9_compatibility-2.patch1.79 KB

Suggested fix

Gvert made their first commit to this issue’s fork.

itamair’s picture

itamair commented
Title: Drupal 9 compatibility » Drupal 9 compatibility for 2.x branch
itamair’s picture

itamair commented
Status: Active » Postponed (maintainer needs more info)

Geocoder 2.x branch is not supported anymore, but still we could mark it compatibile with Drupal 9, if it doesn't contain D9 deprecated/incompatible code.

@gigimaor this #2 patch of you looks just tagging the Geocoder main module (and its submodules) as D9 compatbile,
BUT did you also check its compatibility code? @see: https://www.drupal.org/docs/updating-drupal/how-to-prepare-your-drupal-7...
As I didn't yet ... and not going to process that.
If not we risk to mark 2.x branch as D9 compatible but it is going to break any D9 site ...

gigimaor’s picture

gigimaor
må-or
Location Narangba/Brisbane
commented

Thanks @itamair
Just following the 'upgrade status' module report for this module D9 issues on my Drupal 9 project, and did some functionality tests after the upgrade. That patch was success on my project - hopefully it will serve other the same.

  • itamair committed d1d7a24 on 8.x-2.x authored by gigimaor 
    Issue #3215558 by Gvert, gigimaor: Drupal 9 compatibility for 2.x branch
itamair’s picture

itamair commented
Status: Postponed (maintainer needs more info) » Fixed

New 8.x-2.23 deployed with this ...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.