Field wrappers and customisations not working for node date [#3215220]

Problem/Motivation

The problem is in olivero_preprocess_node. The code overwrites $variables['date'] with just a date. Previously the value was set by template_preprocess_node() and it contains rendered field output.

This leads to missing classes, therefore custom styling might be missed
For the same reason, custom features might not work (e.g. quickedit)
If a site had customised the field display settings using a hook this would be overwritten

Steps to reproduce

Enable quickedit
Enable "Display author and date information" for a content type
Edit a node of that content type

Proposed resolution

There is a clear requirement to customise the date format for a particular theme. However the current solution is probably not the right way to do it. Ideas:

Alter the settings on the field formatter for the created field. Then it would get render correctly by the code in template_preprocess_node. However field formatter settings are not theme specific, so this would have a global effect.
Hook into the pre-processing and alter the date format.

Remaining tasks

Write a patch
Re-enable commented out code in NodeDisplayConfigurableTest.php

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#16	Layout_Builder_Page_Test___Olivero_and_Layout_Builder_Page_Test___Olivero_and_Slack_____parenting___Lullabot.png	146.59 KB	mherchel
#13	Date field quick edit.mp4	1.06 MB	manojithape
#12	Screen Recording 2021-05-27 at 13.32.52.mov	3.31 MB	gauravvvv
#11	After patch sc.png	42.6 KB	manojithape
#11	Before patch sc.png	42.83 KB	manojithape
#9	Screenshot from 2021-05-25 12-22-00.png	50.4 KB	marcusvsouza
#8	Before changes.png	37.58 KB	mitthukumawat
#8	Before changes.png	37.58 KB	mitthukumawat

Issue fork drupal-3215220

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3215220-quickedit-not-working

changes, plain diff MR !705

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 May 2021 at 17:05

AdamPS created an issue. See original summary.

Comment #2

adamps commented 21 May 2021 at 17:08

Issue summary:

View changes

Comment #3

mohit.bansal623 commented 22 May 2021 at 10:59

Status:

Active

» Needs review

Can't we remove that piece of code which is formatting the date in olivero_preprocess_node.

Or we need to show that formatted date along with Quickedit working.

Comment #4

adamps commented 22 May 2021 at 13:45

This code is displaying the date with a particular format 'olivero_medium'.

Maybe a better way to do that is to alter the settings on the field formatter for the created field. Then it would get render correctly by the code in template_preprocess_node.

Comment #5

mohit.bansal623 commented 22 May 2021 at 15:19

What is the requirement ?

To enable quickedit with the current date format the olivero theme is using

Comment #6

23 May 2021 at 06:39

mohit.bansal623 opened merge request !705

Comment #7

mohit.bansal623 commented 23 May 2021 at 06:43

We can create a custom field formatter despite of making changes in preprocess node as that is also blocking quickedit.

Please review.

Comment #8

mitthukumawat commented 24 May 2021 at 07:55

Status	File	Size
new	Before changes.png	37.58 KB
new	Before changes.png	37.58 KB

@mohit.bansal623
The idea above seems working fine.
After removing the dateFormatter from olivero_preprocess_node, the quickedit is able to update the date fields options as well.
By the way, I don't think it is necessary to update the node created field at all. As the node created and updated values in database are useful in case of tracking information of any nodes. Instead, after updating the node, the node created date could be replaced with node updated date.
Apart from above, if it is fine, the changes in merge request fixed this issue. Adding screenshot for reference.

Comment #9

marcusvsouza commented 25 May 2021 at 15:36

Issue summary:

View changes

Status	File	Size
new	Screenshot from 2021-05-25 12-22-00.png	50.4 KB

The commit in comment #6 works as expected, as the attached image shows.

Comment #10

manojithape commented 27 May 2021 at 02:40

Assigned:

Unassigned

» manojithape

Comment #11

manojithape commented 27 May 2021 at 06:19

Assigned:	manojithape	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Status	File	Size
new	Before patch sc.png	42.83 KB
new	After patch sc.png	42.6 KB

Verified and tested patch#6 MR !705 i.e. https://git.drupalcode.org/project/drupal/-/merge_requests/705.patch on the drupal 9.3.x-dev version and Olivero 9.3.0-dev version. Patch applied successfully and looks good to me.

Testing Steps:

Install drupal 9.3.x-dev version.
Go to Appearance -> Set Olivero theme as admin and default theme
Enable quick-edit
Enable "Display author and date information" for a basic page content type
Open any basic page content type node
Click on the quick edit option and observe the administrator user is not able to change/edit the node date.
Now apply the patch and clear the catche.
Again open the same basic page content type and click on the quick edit option.
Verify administrator user is able to change/edit the node date using the quick edit option

Testing Results:

After applying the patch administrator user is able to change/edit the node date using the quick edit option.
Please refer attached Before patch sc and After patch sc images for reference.

Moving this ticket to RTBC.

Comment #12

gauravvvv commented 27 May 2021 at 08:04

Status	File	Size
new	Screen Recording 2021-05-27 at 13.32.52.mov	3.31 MB

After saving changes of quick edit on the date field, the date field disappears after the patch.

Adding screen recording for reference.

Comment #13

manojithape commented 28 May 2021 at 06:27

Status	File	Size
new	Date field quick edit.mp4	1.06 MB

@Gauravmahlawat : The issue which you mentioned in comment #12 not reproducible on my machine. I tested the same on Drupal 9.3.x-dev version. After saving changes of quick edit on the date field, that changes displayed and date field also displayed.
For reference, I attached a screen recording.
Please share the drupal version, so I can try to reproduce on that version.

Comment #14

gauravvvv commented 28 May 2021 at 06:32

@manojithape, I am using D9.3 on Chrome Version 90.0.4430.93 (Official Build) (x86_64)

Comment #15

alexpott

he/they

English

🇪🇺🌍

commented 21 June 2021 at 15:51

Status:	Reviewed & tested by the community	» Needs review
Issue tags:		+Needs subsystem maintainer review

This code exists for a reason - and maybe the implementation is not correct but we should check with the Olivero maintainer before removing code.

Comment #16

mherchel

he/him

English

Gainesville, FL, US

commented 21 June 2021 at 16:55

Priority:	Normal	» Minor
Status:	Needs review	» Needs work
Issue tags:	-Needs subsystem maintainer review

Status	File	Size
new	Layout_Builder_Page_Test___Olivero_and_Layout_Builder_Page_Test___Olivero_and_Slack_____parenting___Lullabot.png	146.59 KB

This code exists for a reason

Yep! The code changes the date format for nodes. We need to ensure that this doesn't regress in any patches.

Comment #17

mherchel

he/him

English

Gainesville, FL, US

commented 9 August 2021 at 13:35

Note that Quickedit will be deprecated. See #3222947: Decide whether to move Quick Edit to contrib. We'll want to move any changes into their own stylesheet, so we can easily remove them if necessary.

Comment #18

xjm

she/her

English

commented 20 August 2021 at 01:19

Issue tags:

+quickedit

Comment #19

20 August 2021 at 01:19

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

20 August 2021 at 01:19

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #21

20 August 2021 at 01:19

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #22

adamps commented 17 February 2023 at 12:22

Title:	Quickedit not working for node date	» Field wrappers and customisations not working for node date
Priority:	Minor	» Normal
Issue summary:	View changes

Updated the IS - I believe this is not only about quickedit.

Comment #23

adamps commented 17 February 2023 at 12:45

Without this, there aren't really any core themes available to test the node date field. This would be a problem, except that the testing (that I spent some time writing) seems to have been deleted from Core anyway see #3342700: Reinstate important testing NodeDisplayConfigurableTest - great work.

Comment #24

17 February 2023 at 12:45

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #25

17 February 2023 at 12:45

Version:

11.x-dev

» main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.