Problem/Motivation

Core css files contains scss syntax which does not work in browser
scss syntax

Steps to reproduce

Open css files:
1) core/themes/stable/css/core/dialog/off-canvas.base.css
2) core/themes/stable/css/core/dialog/off-canvas.reset.css
3) misc/dialog/off-canvas.base.css
4) misc/dialog/off-canvas.reset.css

Proposed resolution

Fix syntax errors in files that have problem.

CommentFileSizeAuthor
#6 drupal_offcanvas-sass-syntax-compiling-issue_3215183.patch43.31 KBvolodymyr soloviov
Screen Shot 2021-05-21 at 5.13.21 PM.png102.32 KBvolodymyr soloviov

Comments

Volodymyr Soloviov created an issue. See original summary.

volodymyr soloviov’s picture

volodymyr soloviov commented
Issue summary: View changes
volodymyr soloviov’s picture

volodymyr soloviov commented
Title: Core off-canvas css files contains scss syntax » Backport postcssPresetEnv and correct the wrong media queries
Issue summary: View changes
volodymyr soloviov’s picture

volodymyr soloviov commented
Status: Needs work » Active
volodymyr soloviov’s picture

volodymyr soloviov commented
Assigned: Unassigned » volodymyr soloviov
volodymyr soloviov’s picture

volodymyr soloviov commented
StatusFileSize
new drupal_offcanvas-sass-syntax-compiling-issue_3215183.patch43.31 KB
chi’s picture

chi commented
Status: Active » Needs review

I cannot reproduce this.

volodymyr soloviov’s picture

volodymyr soloviov commented
Issue summary: View changes
doxigo’s picture

doxigo commented

This is fixed in 9.3.x as far as I checked, but needs to be fixed in 8.9.x as well, the postcss-preset-env package is missing, hence the broken SCSS syntax in a CSS file

chi’s picture

chi commented
Version: 8.9.x-dev » 9.3.x-dev
chi’s picture

chi commented
Version: 9.3.x-dev » 8.9.x-dev
chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community

That's not an issue in 9.x because PostCSS Preset Env was added to 9.x long time ago (#3170864: Add postcss-preset-env).

The patch looks good to me.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Priority: Normal » Major

Bumping to major

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.9.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +Bug Smash Initiative

Drupal 8.9 is now security fixes only.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.