Problem/Motivation

When the UserInfo endpoint is available for given provider, it doesn't use it as the check is not correct.

Also fixed a notice regarding the github provider

Steps to reproduce

Configure the github provider, and try to log in with github.

See attached patch for fix.

CommentFileSizeAuthor
diff.patch1.06 KBtomvanetten

Comments

tomvanetten created an issue. See original summary.

jcnventura’s picture

jcnventura
Primary language English
commented

What is the notice you get with the github provider?

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

I'm committing the userinfo bug fix, as that is an obvious improvement, but I still would like to know what is the notice from Github.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tomvanetten’s picture

tomvanetten commented

Hi Jcventura,

Github doesn't provide an id_token inside the token set, so the line of $tokens['id_token'] puts a notice (undefined index) in to the DB. This check helps for that.

Kind regards,
Tom