Promote the non-stable statuses in admin/appearance page, optionally even visually

Marked #3084816: Determine how to deprecate themes as duplicate.

On #3084816-21: Determine how to deprecate themes Gabor mentioned the possibility of not actually highlighting this on the appearance page, although not sure where that was discussed in more depth.

Bumping this to major since we at least need to discuss it.

I think it depdends on how actionable the information is. That is it deprecated is not useful in itself.

It seems strange to me to indicate non-stable statuses for modules but not themes.

If a theme is deprecated, there are broadly three options:

1. Switch to a contrib version of the same theme.
2. Switch to a different theme.
3. Fork the theme and continue using it.

However at least with core themes, if you're going to do option 1, you don't actually have to switch until you do a major update of core.

To elaborate more, I think its a good idea to indicate non-stable status for themes. Depending on how we can surface the lifecycle link on the UI which would provide the detailed info.

I do think we need to do this in order to deprecate Bartik/Seven/etc.

I borrowed code from ModulesListForm to see what this would look like for themes. Since I have not looked at tests, I am not running the tests.

That looks like a very good start to me.

I added a new test to validate the experimental and deprecated themes on the page on this patch, and also changed the $theme->notes to set the $notes just when we have it, this way we avoid empty parenthesis on the theme name. I'll leave this as NW to see which tests will fail from testbot.

Fix issue summary markup, inline images but keeping them links.

+++ b/core/modules/system/src/Controller/SystemController.php
@@ -347,18 +349,33 @@ public function themesPage() {
+        $notes = Link::fromTextAndUrl($this->t( '@lifecycle', ['@lifecycle' => ucfirst($lifecycle)]),

Tesbot fails on phpcs due to the space in the t( '@lifecycle' here I believe.

Screenshots will need to be updated for the fixed parenthesis.

Hey, fixing phpcs error(#16), I forgot to upload a test-only patch, so here it is.

Thanks!

I updated the screenshots on the IS

Making more changes to the theme notes which will allow the test to pass.

It should be mentioned that the appearance page adds '(experimental)' to experimental theme but that is not done on the modules page. There 'experimental' is not shown unless there is a lifecycle_link. It would be good to have these two page look that same.

This just adds a class 'theme-link--non-stable' and uses that instead of 'module-link--non-stable'.

Here's a draft CR: https://www.drupal.org/node/3262421

Very quick skim of the patch looks good. I hope to have time for a more thorough review in the next few days, but I wanted to at least help this along in some meaningful way with the time I had. ;)

I do agree with @quietone in #20 that it's unfortunate that the handling of 'Experimental' is different. And it's true that the scope for this issue is to get the warnings right on admin/appearance for non-stable themes. So in theory, cleaning up + standardizing experimental could be in scope. But the theme and modules pages already look wildly different, so there's no way we're really going to get parity here. So I'm really not sure we should be holding this up to sort that out. I think a follow-up to address that would be best. Thoughts?

Thanks!
-Derek

Did #21 get deleted by a crosspost? Weirdly, I get a 403 if I try to queue a test for it.

#24
1. No, it didn't make sense but I've reworked the logic.
2. Tacked onto testAdministrationTheme().

Obsolete modules are listed on the modules page so I assume that obsolete themes should be listed. If that is what we want then an obsolete test theme needs to be added and tested.

And I just set a theme to obsolete and then it was successfully installed. ;-)

Ah, obsolete modules should not be shown in the UI according to #3258782-13: Do not display obsolete modules at admin/modules. Since they do show in the UI that will need an issue, if there isn't already one.

Created an issue to remove display of obsolete themes. #3265362: Do not display obsolete themes at admin/appearance

All the code changes look good to me.
I have run the ThemeTest without the fix on my local machine and it fails.
For me it is RTBC.

Uncrediting self.

Added some future proofing. This works locally for 9.4.x and 10.0.x.

Future proofing looks great, thanks! Bot’s happy on both branches. Interdiff is small, clear, simple and means we won’t have to keep changing this test every version. Re-RTBC.

Test change looks great. Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!