Problem/Motivation

If a link is created via twig template, ckeditor, etc. it might not be processed by the Drupal plugin and it will not have the parameters added.

Proposed resolution

Add an option to perform the same functionality via Javascript, where we can target all links after the page has been rendered.

Remaining tasks

Provide a patch for this (WIP).

User interface changes

Added a checkbox to enable/disable the javascript approach.

CommentFileSizeAuthor
#2 3214344-2-wider-reach-links.patch5.77 KBfjgarlin

Issue fork carryquery-3214344

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
StatusFileSize
new 3214344-2-wider-reach-links.patch5.77 KB

This patch adds a new checkbox and when it is checked, then it will add the params to all links via Javascript instead.

manish-31’s picture

manish-31 commented
Status: Needs review » Reviewed & tested by the community

@fjgarlin Thanks for the patch!

The patch applied successfully. Marking it as Reviewd & Tested.

sainathdb made their first commit to this issue’s fork.

sainathdb opened merge request !3

sainathdb closed merge request !3

sainathdb opened merge request !4

  • fjgarlin authored 2f585ae8 on 8.x-1.x 
    Issue #3214344 by fjgarlin, sainathdb, manish-31: Wider reach to links
sainathdb’s picture

sainathdb commented
Assigned: Unassigned » sainathdb
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, committed. though for button clicks it will not work I have included in it

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.