Olivero: RSS block focus is not matching theme color. Now on focus color is black and on hover, it is matching the theme color.

Adding screenshot for reference.

CommentFileSizeAuthor
#17 before_patch7.png15.9 KBsonam.chaturvedi
#17 after_patch7.png16.53 KBsonam.chaturvedi
#14 After--patch--pic.png5.41 KBvikashsoni
#14 before--patch--pic.png5.26 KBvikashsoni
#8 After Patch 3214136.png450.88 KBchetanbharambe
#8 Before Patch 3214136.png452.85 KBchetanbharambe
#7 3214136-7.patch829 byteskostyashupenko
#3 Before-patch.png9.52 KBmitthukumawat
#3 After-patch.png10.55 KBmitthukumawat
#2 3214136-2.patch887 bytesgauravvvv
Screenshot 2021-05-15 at 14.17.11.png21.08 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3214136-2.patch887 bytes

Patch added for same. Please review.

mitthukumawat’s picture

mitthukumawat commented
StatusFileSize
new After-patch.png10.55 KB
new Before-patch.png9.52 KB

I have applied the patch #2 successfully and review the changes on RSS feed block on focus in olivero theme. Patch fixed the focus color to theme color. Adding screenshots for reference.

marcusvsouza’s picture

marcusvsouza commented
Status: Needs review » Reviewed & tested by the community

The patch in the comment #2 works as expected.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Needs work

I'm not really convinced that this is a problem.. I'm on the edge. We have the outline-color set to currentColor so it'll work wherever we want (this will even continue to when we support dark-modes, etc). There are a number of places where the gray and not blue.

However, if we do want to fix this, we shouldn't override the entire outline property, we should just override outline-color.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Priority: Normal » Minor
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review
StatusFileSize
new 3214136-7.patch829 bytes
chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch 3214136.png452.85 KB
new After Patch 3214136.png450.88 KB

Verified and tested patch #7.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Appearance: Set Olivero theme
# See the RSS feed block
# Press tab button to go next interactive element.
# Check the results once the user is on the RSS feed block.

Expected Results:
# RSS block focus should be matched with the theme color.

Actual Results:
# RSS block focus is not matching with the theme color.

Please refer attached screenshots.
Looks good to me.
Can be a move to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3214136-7.patch, failed testing. View results

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review

I have run the test locally and its pass, Also it is passed on #7, So moved to NR.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community

Moving to RTBC based on #8.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3214136-7.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Unrelated failure.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new before--patch--pic.png5.26 KB
new After--patch--pic.png5.41 KB

Applied patch working fine
After patch RSS block focus match with theme color for ref shairng scrrenshot ...

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sonam.chaturvedi’s picture

sonam.chaturvedi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after_patch7.png16.53 KB
new before_patch7.png15.9 KB

Verified and tested patch#7 on 9.5.x-dev. Patch applied successfully.

Test Steps:
1. Goto: Appearance: Set Olivero theme
2. See the RSS feed block
3. Press tab button to go next interactive element.
4. Check the focus colour is matching theme colour

Test Result:
Olivero: RSS block focus is matching theme colour.

Before patch:
bef patch7

After patch:
aftr patch 7

Moving to RTBC

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Closed (works as designed)

AFAIK this is how the focus ring in Olivero is designed to work. I think @mherchel who is a subsystem maintainer of Olivero confirms that on #5.