Umami demo: hover state of buttons is odd on quick edit.

Adding screen recording to reproduce the issue.

CommentFileSizeAuthor
#7 3213957-after-patch.png23.12 KBindrajithkb
#7 3213957-before-patch.png52.13 KBindrajithkb
#3 UmamiTheme- After patch.png384.5 KBmitthukumawat
#3 Seven-buttons.png429.97 KBmitthukumawat
#3 Olivero-On hover.png331.38 KBmitthukumawat
#3 Olivero-Buttons.png264.32 KBmitthukumawat
#3 Bartik-hover.png302.23 KBmitthukumawat
#2 Screenshot 2021-05-14 at 10.51.49.png140.54 KBgauravvvv
#2 border-3213957-2.patch474 bytesgauravvvv
Screen Recording 2021-05-14 at 10.39.39.mov4.98 MBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new border-3213957-2.patch474 bytes
new Screenshot 2021-05-14 at 10.51.49.png140.54 KB

I have added a patch and after patch, screenshot for reference. Please review.

mitthukumawat’s picture

mitthukumawat commented
StatusFileSize
new Bartik-hover.png302.23 KB
new Olivero-Buttons.png264.32 KB
new Olivero-On hover.png331.38 KB
new Seven-buttons.png429.97 KB
new UmamiTheme- After patch.png384.5 KB

I have reproduced this issue in Umami demo profile. I observed while enabled Olivero in Umami, the button UI in quickedit is not appearing as it should be. Similarly I have checked in other themes as well but not showing as expected.
I have reproduced these in chrome in Ubuntu.

I think this issue is appearing different for other browsers also. I have applied the patch #2 but it only fixed the issue for Umami theme.

In short, this patch fixed the current issue in Umami theme but not in other themes.
We may need this patch to work for other themes also, otherwise, these issues should be reported in respective themes for Umami demo.

Adding few screenshots for better explanation.

gauravvvv’s picture

gauravvvv commented

This patch is for umami theme only.

mitthukumawat’s picture

mitthukumawat commented
Status: Needs review » Needs work

Than it is fine.

mitthukumawat’s picture

mitthukumawat commented
Status: Needs work » Needs review
indrajithkb’s picture

indrajithkb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3213957-before-patch.png52.13 KB
new 3213957-after-patch.png23.12 KB

Hi @Gauravmahlawat thanks for the patch, it's working fine.

Attaching SS

Before:
image

After:
image

Moving to RTBC

  • lauriii committed 684f19b on 9.3.x 
    Issue #3213957 by Gauravmahlawat, mitthukumawat, Indrajith KB: Umami...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 684f19b and pushed to 9.3.x. Also cherry-picked to 9.2.x. Thanks!

  • lauriii committed 71a1a0a on 9.2.x 
    Issue #3213957 by Gauravmahlawat, mitthukumawat, Indrajith KB: Umami...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.