Problem/Motivation

The default of the tapToDismiss is TRUE, however one might want to disable it so that on selecting a toast text the notification does not disappear.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3213661-toastr-taptodismiss-5.patch2.34 KBmrinalini9
#3 3213661-toastr-taptodismiss-3.patch2.4 KBszloredan
#2 3213661-2.patch2.66 KBhchonov

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
StatusFileSize
new 3213661-2.patch2.66 KB
szloredan’s picture

szloredan commented
StatusFileSize
new 3213661-toastr-taptodismiss-3.patch2.4 KB

Rerolled the patch to undo the deletion of the rewrite of settings. The extension of that file is missing and handled in this issue: https://www.drupal.org/project/toastr/issues/3172364

omkar-pd’s picture

omkar-pd commented
Status: Needs review » Needs work

this patch needs reroll.

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 3213661-toastr-taptodismiss-5.patch2.34 KB

Rerolled patch #3, please review it.

omkar-pd’s picture

omkar-pd commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • omkar-pd committed 66b81d7 on 8.x-1.x 
    Issue #3213661 by hchonov, szloredan, mrinalini9: Add tapToDismiss...
omkar-pd’s picture

omkar-pd commented
Status: Reviewed & tested by the community » Fixed

Commited, Thanks for the contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.