Problem/Motivation

The image_build_deferred option exists only in the TextimageTextFieldFormatter and not in the TextimageImageFieldFormatter.

Also in the TextimageTextFieldFormatter there is no checkbox to configure this setting.

In my use case I need the image to be generated immediatly because the file is going into an email attachment.

I will provide a patch.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork textimage-3213221

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Please credit https://www.drupal.org/u/gidel for finding the issue and testing on the project.

Grimreaper opened merge request !2

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review

mondrake credited gidel.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
Issue tags: +Needs tests, +Needs update path

Thank you.

We would need automated tests added here, and, I think, an update function to update the default settings for the already existing formatters on the sites.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello,

@mondrake: thanks for the quick reply.

Even if I don't think we will have time to write the automated tests, can you please give some clues on what type of test you expect and if there is exsiting code?

About the update path, I already thought about it and I don't think this is needed because it is a new config setting and the default settings method provides a value that will not change existing behavior. Also to have encountered the problem of updating a field formatter structure #3210558: How to update layout_section fields revisions?, I still don't know how to handle layout builder overrides per entity in revisions

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Closed (outdated)

Closing any stale issue with latest comment over 5 years old.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.