Olivero: wrap breadcrumb items.

breadcrumb items are now hidden after a specific width, these items should be visible and wrapped to the next line.
Adding screenshot for reference.

Issue fork drupal-3213153

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Gauravmahlawat created an issue. See original summary.

marcusvsouza’s picture

Assigned: Unassigned » marcusvsouza
StatusFileSize
new1.32 KB

Here's follows a patch with some work to this problem but needs work!

sakthivel m’s picture

StatusFileSize
new101.42 KB

@Gauravmahlawat breadcrumb items are goes certain width it's enable horizontal scrollbar.

it's working fine & attached screenshot

marcusvsouza’s picture

Assigned: marcusvsouza » Unassigned

nishantghetiya made their first commit to this issue’s fork.

indrajithkb’s picture

Status: Active » Needs work
StatusFileSize
new66.71 KB

Hi @marcusvsouza i have checked your merge request, here you just added the cahnges directly to this file "core/themes/olivero/css/components/breadcrumb.css" . that's why the custom commands getting failed. for this issue you have to do the changes on "core/themes/olivero/css/components/breadcrumb.pcss.css" and compile the css, and add both files.

image

And i have checked your changes manualy and i have seen one ponit, that is you have written

.breadcrumb__item:nth-child(10) {
  clear: left;
}
@media (max-width: 70rem) {
  .breadcrumb__item:nth-child(7) {
    clear: left;
  }
}

But we can't assume the length of the breadcrumb word, if you are adding a breadcrumb with more than 20 words, then we cannot say we can have the break after 7 breadcrumb-item. So please take care this point too.
Please go through this link this will help you to contribute on olivero theme.

Yes i know you are new to contribution.. Hope this will help you. Happy contributing... !!!

marcusvsouza’s picture

Assigned: Unassigned » marcusvsouza
Status: Needs work » Needs review
StatusFileSize
new3 KB
new2.75 KB

@indrajith-kb thanks for the information, follows a new patch witch the necessaries changes. Please revise!

sakthivel m’s picture

StatusFileSize
new2.67 KB

#9 Fixed Custom Commands Failed, recreated patch

marcusvsouza’s picture

Here's a patch correcting the erros from the previous one!

marcusvsouza’s picture

Here's a patch correcting the erros from the previous one!

mherchel’s picture

Status: Needs review » Closed (works as designed)

Thanks for the issue.

The design currently calls for a single line of breadcrumbs within an overflow container. At this point in the process, we're not making changes to the design unless absolutely necessary.