Rename dump-database-d8-mysql option on db-tools.php

I have tested the patch and now I can export the database using "Export" . Thanks for the patch.

I'll work on it.

Fixed failing tests.

+++ b/core/lib/Drupal/Core/Command/DbDumpCommand.php
@@ -39,8 +44,8 @@ class DbDumpCommand extends DbCommandBase {
+    $this->setName('export')

I don't think we should be renaming this command here, just adding the description?

Addressing #11.

+++ b/core/lib/Drupal/Core/Command/DbExportApplication.php
@@ -0,0 +1,43 @@
+    $default_commands[] = new DbDumpCommand();

DbDumpCommand is deprecated. Should be DbExportCommand.

+++ b/core/modules/system/tests/src/Kernel/Scripts/DbToolsApplicationTest.php
@@ -20,8 +20,8 @@ class DbToolsApplicationTest extends KernelTestBase {
-    $command = $application->find('dump');

The 'dump' option is undocumented but referred to on https://www.drupal.org/docs/drupal-apis/migrate-api/generating-database-.... Should the test of it be removed?

Also, DbExportCommand looks like a copy of DbdumpCommand, but it is missing this if block.

I have solved the first point by comment in #12.

Patch #14 changes the wrong file so fixing it.

Should the test of it be removed?

Should we only update the tests and the documentation and ensure that the export command exists?

I added the if block that was missing in the DbExportCommand (This was added after this issue was created. Good catch @quietone).

The patch in comment #15 works fine and correctly changes the command for export database.

I applied that patch and then used 'export' and 'dump' with a drupal 7 database. The output from the commands do not match which I expect them too. I don't think there is any reason that the legacy version needs to be maintained.

There have been changes to DbDumpCommand.php that need to be moved to DbExportCommand, #838992: Change the uid field from integer to serial by leveraging NO_AUTO_VALUE_ON_ZERO on MySQL. There are perhaps ways to change the patch to avoid the disruption here by changes to HEAD but I couldn't find any open issues related to db-tools. It is just unfortunate that there have been recent changes.

I still don't like that tests are being removed. How about we change DbDumpCommand to extend from DbExportCommand and similar for DbDumpApplication. This will simplify the code. Here is an idea for DbDumpCommand.

/**
 * Provides a command to dump the current database to a script.
 *
 * @deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use
 *   \Drupal\Core\Command\DbExportCommand
 *
 * @see https://www.drupal.org/project/drupal/issues/3213151
 */
class DbDumpCommand extends DbExportCommand {

  /**
   * {@inheritdoc}
   */
  protected function configure() {
    $this->setName('dump-database-d8-mysql')
      ->setDescription('Deprecated, use "export" instead.')
      ->addOption('schema-only', NULL, InputOption::VALUE_OPTIONAL, 'A comma separated list of tables to only export the schema without data.', 'cache.*,sessions,watchdog');
    DbCommandBase::configure();
  }

1. +++ b/core/lib/Drupal/Core/Command/DbDumpCommand.php
   @@ -23,6 +23,11 @@
   + * @deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use
   + *   \Drupal\Core\Command\DbExportCommand
   
   @@ -40,7 +45,7 @@ class DbDumpCommand extends DbCommandBase {
   +      ->setDescription('Deprecated, use "export" instead.')
   

   This is nice, but when I ran the command I expected to be informed of when it will be deprecated. Can this be "Deprecated in Drupal:9.3.0 and is removed from Drupal:10.0.0. Use 'export' instead."

2. +++ b/core/lib/Drupal/Core/Command/DbExportCommand.php
   @@ -0,0 +1,452 @@
   +      ->setDescription('Export the current database to a generation script.')
   

   I realize this is from the Dump command but it isn't correct. This will export other databases, not just the current one. How about something like, "Export a database to a generation script."?

Working on it.

The changes that I made are:

1 - Added #3228237: Always sort tables in db-tools.php dump and #838992: Change the uid field from integer to serial by leveraging NO_AUTO_VALUE_ON_ZERO on MySQL to the DbExportCommand.php file.
2 - Changed DbDumpCommand.php to extend DbExportCommand.php
3 - Changed DbDumpApplication.php to extend DbExportApplication.php
4 - Updated deprecation message.
5 - Updated DbExportCommand message description.

New patch.