Problem/Motivation

In #2826722: Add a 'fence' around settings tray with aggressive CSS reset. a selector #drupal-off-canvas input:placeholder was added. I guess that was wrong and should have been ::placeholder.

CommentFileSizeAuthor
#5 3212470-5.patch1.2 KBgauravvvv

Issue fork drupal-3212470

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JeroenT created an issue. See original summary.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes

JeroenT opened merge request !633

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Active » Needs review
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3212470-5.patch1.2 KB

In D9.3 the :placeholder is used only twice in drupal/core/themes/stable/css/core/dialog/off-canvas.reset.pcss.css, I have resolved this issue and provided a patch. Please review.


Missed stable D9.

gauravvvv’s picture

gauravvvv commented
Madhu kumar’s picture

Madhu kumar commented

Above patch applied cleanly and working as expected a selector #drupal-off-canvas input:placeholder is removed.

RTBC +1

radheymkumar’s picture

radheymkumar commented

Patch applied successfully and working fine

vikashsoni’s picture

vikashsoni commented

@Gauravmahlawat thanks for the patch
patch applied successfully
After patch selector #drupal-off-canvas input:placeholder has been removed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

This fix is correct, pseudo-elements use :: as the selector prefix. This can also be seen by the fact that PostCSS expands ::placeholder for IE whereas it did not for :placeholder.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

I re-ran yarn run build:css on Drupal 10.0.x because we've dropped IE support.

Committed a4e507d and pushed to 10.0.x. Thanks!
Committed and pushed 1d4766cd5fd to 9.4.x and 3e6bdf7eb88 to 9.3.x. Thanks!

  • alexpott committed a4e507d on 10.0.x 
    Issue #3212470 by JeroenT, Gauravmahlawat: Placeholder CSS selector in...

  • alexpott committed 1d4766c on 9.4.x 
    Issue #3212470 by JeroenT, Gauravmahlawat: Placeholder CSS selector in...

  • alexpott committed 3e6bdf7 on 9.3.x 
    Issue #3212470 by JeroenT, Gauravmahlawat: Placeholder CSS selector in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.