Problem/Motivation

After running a PHPCO Compatibility checker, 11 errors are reported in the CalendarEventController.php file.

ERROR Indirect access to variables, properties and methods will be evaluated strictly in left-to-right order since PHP 7.0. Use curly braces to remove ambiguity.

Steps to reproduce

From the command line:
phpco -p --extensions=php,inc,module --report-code=php-74-audit.txt --runtime-set testVersion 7.4 ./modules/contrib/fullcalendar_view

https://github.com/fortrabbit/phpco-docker

Proposed resolution

Patch

Remaining tasks

Review

User interface changes

None

API changes

None

Data model changes

None

Issue fork fullcalendar_view-3212002

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jacqui.Tenderwolf created an issue. See original summary.

Jacqui.Tenderwolf opened merge request !14

mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Active » Fixed

Thanks.

mrogers’s picture

mrogers commented
Status: Fixed » Active

This update is giving me the following error when running Drush tasks on my site:

ParseError: syntax error, unexpected '{' in /app/web/modules/contrib/fullcalendar_view/src/Controller/CalendarEventController.php on line 87 #0 [internal function]: Symfony\Component\ClassLoader\ApcClassLoader->loadClass('Drupal\\fullcale...')

  • 6530f38 committed on 8.x-2.x 
    Issue #3212002 by Jacqui.Tenderwolf, Mingsong, mrogers: PHP 7.4...
mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Active » Fixed

Thank mrogers for reporting it.

I just push the fix for it.

mrogers’s picture

mrogers commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.